Skip to content

Commit 52f4d82

Browse files
committed
No need to install cgi gem manually because Ruby 3.2.0 ships cgi 0.3.6 as a default gem
This commit removes the workaround via rails#46595 because the current Rails main branch requires Ruby 3.2.0 that ships cgi 0.3.6 as a default gem. - Ruby 3.2.0 Released https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/ > The following default gems are updated. > cgi 0.3.6 Using cgi gem 0.3.6 installed with Ruby 3.2.0 as a default gem passes the test when it uses cgi 0.3.5. ``` $ ruby -v ruby 3.2.0 (2022-12-25 revision a528908271) [x86_64-linux] $ cd rails/actionpack $ bundle install Bundle complete! 87 Gemfile dependencies, 237 gems now installed. Use `bundle info [gemname]` to see where a bundled gem is installed. $ bundle info cgi * cgi (0.3.6) Summary: Support for the Common Gateway Interface protocol. Homepage: https://github.com/ruby/cgi Source Code: https://github.com/ruby/cgi Path: /home/yahonda/.rbenv/versions/3.2.0/lib/ruby/gems/3.2.0/gems/cgi-0.3.6 Default Gem: yes $ bin/test test/dispatch/session/cookie_store_test.rb -n test_session_store_with_all_domains Running 27 tests in a single process (parallelization threshold is 50) Run options: -n test_session_store_with_all_domains --seed 59282 . Finished in 0.107261s, 9.3231 runs/s, 18.6461 assertions/s. 1 runs, 2 assertions, 0 failures, 0 errors, 0 skips $ ```
1 parent 10cd569 commit 52f4d82

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

Gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ gem "terser", ">= 1.1.4", require: false
4040
# Explicitly avoid 1.x that doesn't support Ruby 2.4+
4141
gem "json", ">= 2.0.0", "!=2.7.0"
4242

43-
# Workaround until Ruby ships with cgi version 0.3.6 or higher.
44-
gem "cgi", ">= 0.3.6", require: false
45-
4643
# Workaround until all supported Ruby versions ship with uri version 0.13.1 or higher.
4744
gem "uri", ">= 0.13.1", require: false
4845

Gemfile.lock

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,6 @@ GEM
191191
rack-test (>= 0.6.3)
192192
regexp_parser (>= 1.5, < 3.0)
193193
xpath (~> 3.2)
194-
cgi (0.4.1)
195194
chef-utils (18.3.0)
196195
concurrent-ruby
197196
concurrent-ruby (1.3.3)
@@ -658,7 +657,6 @@ DEPENDENCIES
658657
bootsnap (>= 1.4.4)
659658
brakeman
660659
capybara (>= 3.39)
661-
cgi (>= 0.3.6)
662660
connection_pool
663661
cssbundling-rails
664662
dalli (>= 3.0.1)

0 commit comments

Comments
 (0)