Merge pull request rails#43211 from 9sako6/fix_nameerror_when_an_invalid_option_is_given_to_on

Fix `NameError` when an invalid `:on` option is given to a route

Author: kamipo

actionpack/lib/action_dispatch/routing/mapper.rb

@@ -1861,7 +1861,7 @@ def path_scope(path)
           end
 
           def map_match(paths, options)
-            if options[:on] && !VALID_ON_OPTIONS.include?(options[:on])
+            if (on = options[:on]) && !VALID_ON_OPTIONS.include?(on)
               raise ArgumentError, "Unknown scope #{on.inspect} given to :on"
             end
 

actionpack/test/dispatch/mapper_test.rb

@@ -193,6 +193,16 @@ def test_raising_error_when_rack_app_is_not_passed
         end
       end
 
+      def test_raising_error_when_invalid_on_option_is_given
+        fakeset = FakeSet.new
+        mapper = Mapper.new fakeset
+        error = assert_raise ArgumentError do
+          mapper.get "/foo", on: :invalid_option
+        end
+
+        assert_equal "Unknown scope :invalid_option given to :on", error.message
+      end
+
       def test_scope_does_not_destructively_mutate_default_options
         fakeset = FakeSet.new
         mapper = Mapper.new fakeset