Skip to content

Commit 5e51dac

Browse files
remove removed seamless attribute
https://caniuse.com/?search=seamless Chrome 20-26 had partial support behind a flag, though this was later removed.
1 parent cf1626e commit 5e51dac

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

railties/lib/rails/templates/rails/mailers/email.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
</header>
125125

126126
<% if @part && @part.mime_type %>
127-
<iframe seamless name="messageBody" src="?<%= part_query(@part.mime_type) %>"></iframe>
127+
<iframe name="messageBody" src="?<%= part_query(@part.mime_type) %>"></iframe>
128128
<% else %>
129129
<p>
130130
You are trying to preview an email that does not have any content.

railties/test/application/mailer_previews_test.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ def foo
585585

586586
get "/rails/mailers/notifier/foo.txt"
587587
assert_equal 200, last_response.status
588-
assert_match '<iframe seamless name="messageBody" src="?part=text%2Fplain">', last_response.body
588+
assert_match '<iframe name="messageBody" src="?part=text%2Fplain">', last_response.body
589589
assert_match '<option selected value="part=text%2Fplain">', last_response.body
590590
assert_match '<option value="part=text%2Fhtml">', last_response.body
591591

@@ -595,7 +595,7 @@ def foo
595595

596596
get "/rails/mailers/notifier/foo.html?name=Ruby"
597597
assert_equal 200, last_response.status
598-
assert_match '<iframe seamless name="messageBody" src="?name=Ruby&amp;part=text%2Fhtml">', last_response.body
598+
assert_match '<iframe name="messageBody" src="?name=Ruby&amp;part=text%2Fhtml">', last_response.body
599599
assert_match '<option selected value="name=Ruby&amp;part=text%2Fhtml">', last_response.body
600600
assert_match '<option value="name=Ruby&amp;part=text%2Fplain">', last_response.body
601601

@@ -634,7 +634,7 @@ def foo
634634

635635
get "/rails/mailers/notifier/foo"
636636
assert_equal 200, last_response.status
637-
assert_match %r[<iframe seamless name="messageBody"], last_response.body
637+
assert_match %r[<iframe name="messageBody"], last_response.body
638638

639639
get "/rails/mailers/notifier/foo?part=text/plain"
640640
assert_equal 200, last_response.status
@@ -675,7 +675,7 @@ def foo
675675

676676
get "/rails/mailers/notifier/foo"
677677
assert_equal 200, last_response.status
678-
assert_match %r[<iframe seamless name="messageBody"], last_response.body
678+
assert_match %r[<iframe name="messageBody"], last_response.body
679679

680680
get "/rails/mailers/notifier/foo?part=text/plain"
681681
assert_equal 200, last_response.status
@@ -721,7 +721,7 @@ def foo
721721

722722
get "/rails/mailers/notifier/foo"
723723
assert_equal 200, last_response.status
724-
assert_match %r[<iframe seamless name="messageBody"], last_response.body
724+
assert_match %r[<iframe name="messageBody"], last_response.body
725725

726726
get "/rails/mailers/notifier/foo?part=text/plain"
727727
assert_equal 200, last_response.status
@@ -779,7 +779,7 @@ def foo
779779

780780
get "/rails/mailers/notifier/foo"
781781
assert_equal 200, last_response.status
782-
assert_match %r[<iframe seamless name="messageBody"], last_response.body
782+
assert_match %r[<iframe name="messageBody"], last_response.body
783783

784784
get "/rails/mailers/notifier/foo?part=text/plain"
785785
assert_equal 200, last_response.status

0 commit comments

Comments
 (0)