Merge pull request rails#49890 from fatkodima/fix-mariadb-on_duplicate-skip

Do not use `INSERT IGNORE` when upserting to MariaDB

Author: jhawthorn

activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb

@@ -639,11 +639,12 @@ def default_index_type?(index) # :nodoc:
       end
 
       def build_insert_sql(insert) # :nodoc:
-        sql = +"INSERT"
-        sql << " IGNORE" if insert.skip_duplicates?
-        sql << " #{insert.into} #{insert.values_list}"
+        sql = +"INSERT #{insert.into} #{insert.values_list}"
 
-        if insert.update_duplicates?
+        if insert.skip_duplicates?
+          no_op_column = quote_column_name(insert.keys.first)
+          sql << " ON DUPLICATE KEY UPDATE #{no_op_column}=#{no_op_column}"
+        elsif insert.update_duplicates?
           sql << " ON DUPLICATE KEY UPDATE "
           if insert.raw_update_sql?
             sql << insert.raw_update_sql

activerecord/test/cases/insert_all_test.rb

@@ -129,6 +129,16 @@ def test_insert_all_can_skip_duplicate_records
     end
   end
 
+  if current_adapter?(:Mysql2Adapter, :TrilogyAdapter)
+    def test_insert_all_generates_correct_sql
+      skip unless supports_insert_on_duplicate_skip?
+
+      assert_sql(/ON DUPLICATE KEY UPDATE/) do
+        Book.insert_all [{ id: 1, name: "Agile Web Development with Rails" }]
+      end
+    end
+  end
+
   def test_insert_all_with_skip_duplicates_and_autonumber_id_not_given
     skip unless supports_insert_on_duplicate_skip?