Skip to content

Commit 63a2aea

Browse files
author
David Heinemeier Hansson
authored
rack-mini-profiler interferes with etag cache testing (rails#42986)
So turn it off by default, but continue to suggest it.
1 parent adec7e7 commit 63a2aea

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

railties/lib/rails/generators/rails/app/templates/Gemfile.tt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ group :development do
5151
<%- else -%>
5252
gem "web-console", ">= 4.1.0"
5353
<%- end -%>
54-
# Display performance information such as SQL time and flame graphs for each request in your browser.
55-
# Can be configured to work on production as well see: https://github.com/MiniProfiler/rack-mini-profiler/blob/master/README.md
56-
gem "rack-mini-profiler", "~> 2.0"
54+
# Display speed badge on every html page with SQL times and flame graphs.
55+
# Note: Interferes with etag cache testing. Can be configured to work on production: https://github.com/MiniProfiler/rack-mini-profiler/blob/master/README.md
56+
# gem "rack-mini-profiler", "~> 2.0"
5757
<%- end -%>
5858
<% if depend_on_listen? -%>
5959
gem "listen", "~> 3.3"

railties/test/generators/app_generator_test.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1281,7 +1281,6 @@ def test_minimal_rails_app
12811281

12821282
assert_no_gem "webpacker", app_root
12831283
assert_no_gem "jbuilder", app_root
1284-
assert_no_gem "rack-mini-profiler", app_root
12851284
assert_no_gem "spring", app_root
12861285
assert_no_gem "web-console", app_root
12871286
end

0 commit comments

Comments
 (0)