Move node table name compilation to to_sql visitor

Author: palkan

activerecord/lib/arel/table.rb

@@ -14,7 +14,6 @@ def initialize(name, as: nil, klass: nil, type_caster: klass&.type_caster)
       @name =
         case name
         when Symbol then name.to_s
-        when Nodes::Node then Arel.sql(name.to_sql)
         else
           name
         end

activerecord/lib/arel/visitors/to_sql.rb

@@ -569,11 +569,17 @@ def visit_Arel_Nodes_Not(o, collector)
         end
 
         def visit_Arel_Table(o, collector)
-          if o.table_alias
-            collector << quote_table_name(o.name) << " " << quote_table_name(o.table_alias)
+          if Arel::Nodes::Node === o.name
+            visit o.name, collector
           else
             collector << quote_table_name(o.name)
           end
+
+          if o.table_alias
+            collector << " " << quote_table_name(o.table_alias)
+          end
+
+          collector
         end
 
         def visit_Arel_Nodes_In(o, collector)

activerecord/test/cases/arel/table_test.rb

@@ -130,15 +130,13 @@ class TableTest < Arel::Spec
 
       it "should accept literal SQL"  do
         rel = Table.new Arel.sql("generate_series(4, 2)")
-        manager = rel.project(Arel.star)
-        _(manager.to_sql).must_be_like %{ SELECT * FROM generate_series(4, 2) }
+        assert_equal Arel.sql("generate_series(4, 2)"), rel.name
       end
 
       it "should accept Arel nodes"  do
         node = Arel::Nodes::NamedFunction.new("generate_series", [4, 2])
         rel = Table.new node
-        manager = rel.project(Arel.star)
-        _(manager.to_sql).must_be_like %{ SELECT * FROM generate_series(4, 2) }
+        assert_equal node, rel.name
       end
     end
 

activerecord/test/cases/arel/visitors/to_sql_test.rb

@@ -696,6 +696,31 @@ def dispatch
         end
       end
 
+      describe "Table" do
+        it "should compile node names" do
+          test = Table.new(:users).alias("zomgusers")[:id].eq "3"
+          _(compile(test)).must_be_like %{
+            "zomgusers"."id" = '3'
+          }
+        end
+
+        it "should compile literal SQL"  do
+          test = Table.new Arel.sql("generate_series(4, 2)")
+          _(compile(test)).must_be_like %{ generate_series(4, 2) }
+        end
+
+        it "should compile Arel nodes"  do
+          test = Arel::Nodes::NamedFunction.new("generate_series", [4, 2])
+          _(compile(test)).must_be_like %{ generate_series(4, 2) }
+        end
+
+        it "should compile nodes with bind params" do
+          bp = Nodes::BindParam.new(1)
+          test = Arel::Nodes::NamedFunction.new("generate_series", [4, bp])
+          _(compile(test)).must_be_like %{ generate_series(4, ?) }
+        end
+      end
+
       describe "TableAlias" do
         it "should use the underlying table for checking columns" do
           test = Table.new(:users).alias("zomgusers")[:id].eq "3"