Remove sucker_punch ActiveJob::Queue adapter (rails#52935)

* Remove sucker_punch ActiveJob::Queue adapter

Removes sucker_punch dependecy.
SuckerPunch existed before ActiveJob, but ultimately uses similar code to `AsyncAdapter` under the covers.

* Update CHANGELOG.md

---------

Co-authored-by: David Heinemeier Hansson <[email protected]>

Author: dixpac

Gemfile

@@ -104,7 +104,6 @@ group :job do
   gem "resque", require: false
   gem "resque-scheduler", require: false
   gem "sidekiq", require: false
-  gem "sucker_punch", require: false
   gem "delayed_job", require: false
   gem "queue_classic", ">= 4.0.0", require: false, platforms: :ruby
   gem "sneakers", require: false

Gemfile.lock

@@ -584,8 +584,6 @@ GEM
     stimulus-rails (1.3.0)
       railties (>= 6.0.0)
     stringio (3.1.1)
-    sucker_punch (3.2.0)
-      concurrent-ruby (~> 1.0)
     syntax_tree (6.1.1)
       prettier_print (>= 1.2.0)
     tailwindcss-rails (2.1.0)
@@ -713,7 +711,6 @@ DEPENDENCIES
   sqlite3 (>= 2.0)
   stackprof
   stimulus-rails
-  sucker_punch
   syntax_tree (= 6.1.1)
   tailwindcss-rails
   terser (>= 1.1.4)

activejob/CHANGELOG.md

@@ -1,3 +1,8 @@
+*   Remove `sucker_punch` as an adapter option [since author himself recommends using AJ's own AsyncAdapter](https://github.com/brandonhilkert/sucker_punch?tab=readme-ov-file#faq).
+    If you're using this adapter, change to `adapter: async` for the same functionality.
+
+    *Dino Maric*
+
 *   Use `RAILS_MAX_THREADS` in `ActiveJob::AsyncAdapter`. If it is not set, use 5 as default.
 
     *heka1024*

activejob/Rakefile

@@ -2,7 +2,7 @@
 
 require "rake/testtask"
 
-ACTIVEJOB_ADAPTERS = %w(async inline delayed_job queue_classic resque sidekiq sneakers sucker_punch backburner test)
+ACTIVEJOB_ADAPTERS = %w(async inline delayed_job queue_classic resque sidekiq sneakers backburner test)
 ACTIVEJOB_ADAPTERS.delete("queue_classic") if defined?(JRUBY_VERSION)
 
 task default: :test

activejob/lib/active_job/queue_adapters.rb

@@ -12,7 +12,6 @@ module ActiveJob
   # * {Resque}[https://github.com/resque/resque]
   # * {Sidekiq}[https://sidekiq.org]
   # * {Sneakers}[https://github.com/jondot/sneakers]
-  # * {Sucker Punch}[https://github.com/brandonhilkert/sucker_punch]
   # * Please Note: We are not accepting pull requests for new adapters. See the {README}[link:files/activejob/README_md.html] for more details.
   #
   # For testing and development Active Job has three built-in adapters:
@@ -32,7 +31,6 @@ module ActiveJob
   #   | Resque            | Yes   | Yes    | Yes (Gem)  | Queue      | Global  | Yes     |
   #   | Sidekiq           | Yes   | Yes    | Yes        | Queue      | No      | Job     |
   #   | Sneakers          | Yes   | Yes    | No         | Queue      | Queue   | No      |
-  #   | Sucker Punch      | Yes   | Yes    | Yes        | No         | No      | No      |
   #   | Active Job Async  | Yes   | Yes    | Yes        | No         | No      | No      |
   #   | Active Job Inline | No    | Yes    | N/A        | N/A        | N/A     | N/A     |
   #   | Active Job Test   | No    | Yes    | N/A        | N/A        | N/A     | N/A     |
@@ -124,7 +122,6 @@ module QueueAdapters
     autoload :ResqueAdapter
     autoload :SidekiqAdapter
     autoload :SneakersAdapter
-    autoload :SuckerPunchAdapter
     autoload :TestAdapter
 
     ADAPTER = "Adapter"

activejob/lib/active_job/queue_adapters/sucker_punch_adapter.rb

@@ -41,8 +41,6 @@ def test_set_test_adapter
                  ActiveJob::QueueAdapters::SidekiqAdapter
                when :sneakers
                  ActiveJob::QueueAdapters::SneakersAdapter
-               when :sucker_punch
-                 ActiveJob::QueueAdapters::SuckerPunchAdapter
                else
                  raise NotImplementedError.new
     end

activejob/test/adapters/sucker_punch.rb

@@ -13,7 +13,7 @@ class QueuingTest < ActiveSupport::TestCase
     assert_job_executed
   end
 
-  unless adapter_is?(:inline, :async, :sucker_punch)
+  unless adapter_is?(:inline, :async)
     test "should not run jobs queued on a non-listening queue" do
       old_queue = TestJob.queue_name