Merge pull request rails#47863 from aharpole/fix-create-table-index-name-compatibility

Ensure pre-7.1 migrations use legacy index names when using create_table

Author: jhawthorn

activerecord/lib/active_record/migration/compatibility.rb

@@ -33,7 +33,36 @@ def self.find(version)
       V7_1 = Current
 
       class V7_0 < V7_1
+        module LegacyIndexName
+          private
+            def legacy_index_name(table_name, options)
+              if Hash === options
+                if options[:column]
+                  "index_#{table_name}_on_#{Array(options[:column]) * '_and_'}"
+                elsif options[:name]
+                  options[:name]
+                else
+                  raise ArgumentError, "You must specify the index name"
+                end
+              else
+                legacy_index_name(table_name, index_name_options(options))
+              end
+            end
+
+            def index_name_options(column_names)
+              if expression_column_name?(column_names)
+                column_names = column_names.scan(/\w+/).join("_")
+              end
+
+              { column: column_names }
+            end
+
+            def expression_column_name?(column_name)
+              column_name.is_a?(String) && /\W/.match?(column_name)
+            end
+        end
         module TableDefinition
+          include LegacyIndexName
           def column(name, type, **options)
             options[:_skip_validate_options] = true
             super
@@ -44,11 +73,18 @@ def change(name, type, **options)
             super
           end
 
+          def index(column_name, **options)
+            options[:name] = legacy_index_name(name, column_name) if options[:name].nil?
+            super
+          end
+
           private
             def raise_on_if_exist_options(options)
             end
         end
 
+        include LegacyIndexName
+
         def add_column(table_name, column_name, type, **options)
           options[:_skip_validate_options] = true
           super
@@ -109,32 +145,6 @@ class << t
             end
             super
           end
-
-          def legacy_index_name(table_name, options)
-            if Hash === options
-              if options[:column]
-                "index_#{table_name}_on_#{Array(options[:column]) * '_and_'}"
-              elsif options[:name]
-                options[:name]
-              else
-                raise ArgumentError, "You must specify the index name"
-              end
-            else
-              legacy_index_name(table_name, index_name_options(options))
-            end
-          end
-
-          def index_name_options(column_names)
-            if expression_column_name?(column_names)
-              column_names = column_names.scan(/\w+/).join("_")
-            end
-
-            { column: column_names }
-          end
-
-          def expression_column_name?(column_name)
-            column_name.is_a?(String) && /\W/.match?(column_name)
-          end
       end
 
       class V6_1 < V7_0

activerecord/test/cases/migration/compatibility_test.rb

@@ -566,6 +566,28 @@ def migrate(x)
         assert_match(/is too long/i, error.message)
       end
 
+      def test_create_table_add_index_errors_on_too_long_name_7_0
+        migration = Class.new(ActiveRecord::Migration[7.0]) {
+          def migrate(x)
+            create_table :more_testings do |t|
+              t.integer :foo
+              t.integer :bar
+              t.integer :very_long_column_name_to_test_with
+              t.index [:foo, :bar, :very_long_column_name_to_test_with]
+            end
+          end
+        }.new
+
+        error = assert_raises(StandardError) do
+          ActiveRecord::Migrator.new(:up, [migration], @schema_migration, @internal_metadata).migrate
+        end
+
+        assert_match(/index_more_testings_on_foo_and_bar_and_very_long_column_name_to_test_with/i, error.message)
+        assert_match(/is too long/i, error.message)
+      ensure
+        connection.drop_table :more_testings rescue nil
+      end
+
       def test_add_reference_on_6_0
         create_migration = Class.new(ActiveRecord::Migration[6.0]) {
           def version; 100 end