Merge pull request rails#47929 from jetjodh/patch-1

zzak · web-flow · commit 767653ab1070 · 2023-04-13T07:34:02.000+09:00
fixed comment for example sql statement
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
@@ -322,7 +322,7 @@ def async_pick(*column_names)
     # Returns the base model's ID's for the relation using the table's primary key
     #
     #   Person.ids # SELECT people.id FROM people
-    #   Person.joins(:companies).ids # SELECT people.id FROM people INNER JOIN companies ON companies.person_id = people.id
+    #   Person.joins(:companies).ids # SELECT people.id FROM people INNER JOIN companies ON companies.id = people.company_id
     def ids
       if loaded?
         result = records.pluck(*Array(primary_key))

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,7 @@ def async_pick(*column_names)`
`322`	`322`	`# Returns the base model's ID's for the relation using the table's primary key`
`323`	`323`	`#`
`324`	`324`	`# Person.ids # SELECT people.id FROM people`
`325`		`- # Person.joins(:companies).ids # SELECT people.id FROM people INNER JOIN companies ON companies.person_id = people.id`
	`325`	`+ # Person.joins(:companies).ids # SELECT people.id FROM people INNER JOIN companies ON companies.id = people.company_id`
`326`	`326`	`def ids`
`327`	`327`	`if loaded?`
`328`	`328`	`result = records.pluck(*Array(primary_key))`