Remove deprecated support to Model.reorder(nil).first to search using non-deterministic order.

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated support to `Model.reorder(nil).first` to search using non-deterministic order.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated rake tasks:
 
     * `db:schema:load_if_ruby`

activerecord/lib/active_record/relation/finder_methods.rb

@@ -140,8 +140,6 @@ def find_sole_by(arg, *args)
     #   Person.first(3) # returns the first three objects fetched by SELECT * FROM people ORDER BY people.id LIMIT 3
     #
     def first(limit = nil)
-      check_reorder_deprecation unless loaded?
-
       if limit
         find_nth_with_limit(0, limit)
       else
@@ -390,17 +388,6 @@ def raise_record_not_found_exception!(ids = nil, result_size = nil, expected_siz
     end
 
     private
-      def check_reorder_deprecation
-        if !order_values.empty? && order_values.all?(&:blank?)
-          blank_value = order_values.first
-          ActiveSupport::Deprecation.warn(<<~MSG.squish)
-            `.reorder(#{blank_value.inspect})` with `.first` / `.first!` no longer
-            takes non-deterministic result in Rails 7.0.
-            To continue taking non-deterministic result, use `.take` / `.take!` instead.
-          MSG
-        end
-      end
-
       def construct_relation_for_exists(conditions)
         conditions = sanitize_forbidden_attributes(conditions)
 

activerecord/lib/active_record/relation/query_methods.rb

@@ -448,14 +448,14 @@ def in_order_of(column, values)
     # generates a query with 'ORDER BY id ASC, name ASC'.
     def reorder(*args)
       check_if_method_has_arguments!(__callee__, args) do
-        sanitize_order_arguments(args) unless args.all?(&:blank?)
+        sanitize_order_arguments(args)
       end
       spawn.reorder!(*args)
     end
 
     # Same as #reorder but operates on relation in-place instead of copying.
     def reorder!(*args) # :nodoc:
-      preprocess_order_args(args) unless args.all?(&:blank?)
+      preprocess_order_args(args)
       args.uniq!
       self.reordering_value = true
       self.order_values = args

activerecord/test/cases/relations_test.rb

@@ -1821,17 +1821,14 @@ def test_reverse_order_with_reorder_nil_removes_the_order
   end
 
   def test_reorder_with_first
+    post = nil
+
     sql_log = capture_sql do
-      message = <<~MSG.squish
-        `.reorder(nil)` with `.first` / `.first!` no longer
-        takes non-deterministic result in Rails 7.0.
-        To continue taking non-deterministic result, use `.take` / `.take!` instead.
-      MSG
-      assert_deprecated(message) do
-        assert Post.order(:title).reorder(nil).first
-      end
+      post = Post.order(:title).reorder(nil).first
     end
-    assert sql_log.all? { |sql| !/order by/i.match?(sql) }, "ORDER BY was used in the query: #{sql_log}"
+
+    assert_equal posts(:welcome), post
+    assert sql_log.any? { |sql| /order by/i.match?(sql) }, "ORDER BY was not used in the query: #{sql_log}"
   end
 
   def test_reorder_with_take

guides/source/7_0_release_notes.md

@@ -137,6 +137,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
     * `db:test:load_structure`
     * `db:test:load_structure:#{name}`
 
+*   Remove deprecated support to `Model.reorder(nil).first` to search using non-deterministic order.
+
 ### Deprecations
 
 ### Notable changes