Merge pull request rails#49837 from jonathanhefner/string-xcase_first-non-frozen-empty-string

Ensure `{down,up}case_first` returns non-frozen string

Author: jonathanhefner

activesupport/lib/active_support/inflector/methods.rb

@@ -164,7 +164,7 @@ def humanize(lower_case_and_underscored_word, capitalize: true, keep_id_suffix:
     #   upcase_first('w')                 # => "W"
     #   upcase_first('')                  # => ""
     def upcase_first(string)
-      string.length > 0 ? string[0].upcase.concat(string[1..-1]) : ""
+      string.length > 0 ? string[0].upcase.concat(string[1..-1]) : +""
     end
 
     # Converts the first character in the string to lowercase.
@@ -173,7 +173,7 @@ def upcase_first(string)
     #   downcase_first('I')                          # => "i"
     #   downcase_first('')                           # => ""
     def downcase_first(string)
-      string.length > 0 ? string[0].downcase.concat(string[1..-1]) : ""
+      string.length > 0 ? string[0].downcase.concat(string[1..-1]) : +""
     end
 
     # Capitalizes all the words and replaces some characters in the string to

activesupport/test/core_ext/string_ext_test.rb

@@ -100,6 +100,7 @@ def test_downcase_first_with_one_char
 
   def test_downcase_first_with_empty_string
     assert_equal "", "".downcase_first
+    assert_not_predicate "".downcase_first, :frozen?
   end
 
   def test_upcase_first
@@ -112,6 +113,7 @@ def test_upcase_first_with_one_char
 
   def test_upcase_first_with_empty_string
     assert_equal "", "".upcase_first
+    assert_not_predicate "".upcase_first, :frozen?
   end
 
   def test_camelize