Merge pull request rails#49723 from mylesboone/activestorage_touch_config

Add config option to not touch records

Author: rafaelfranca

activestorage/app/models/active_storage/attachment.rb

@@ -24,7 +24,7 @@ class ActiveStorage::Attachment < ActiveStorage::Record
   # :method:
   #
   # Returns the associated record.
-  belongs_to :record, polymorphic: true, touch: true
+  belongs_to :record, polymorphic: true, touch: ActiveStorage.touch_attachment_records
 
   ##
   # :method:

activestorage/app/models/active_storage/blob.rb

@@ -47,7 +47,7 @@ class ActiveStorage::Blob < ActiveStorage::Record
     self.service_name ||= self.class.service&.name
   end
 
-  after_update :touch_attachment_records
+  after_update :touch_attachments
 
   after_update_commit :update_service_metadata, if: -> { content_type_previously_changed? || metadata_previously_changed? }
 
@@ -376,8 +376,14 @@ def service_metadata
       end
     end
 
-    def touch_attachment_records
-      attachments.includes(:record).each do |attachment|
+    def touch_attachments
+      attachments.then do |relation|
+        if ActiveStorage.touch_attachment_records
+          relation.includes(:record)
+        else
+          relation
+        end
+      end.each do |attachment|
         attachment.touch
       end
     end

activestorage/lib/active_storage.rb

@@ -354,6 +354,7 @@ module ActiveStorage
   mattr_accessor :unsupported_image_processing_arguments
 
   mattr_accessor :service_urls_expire_in, default: 5.minutes
+  mattr_accessor :touch_attachment_records, default: true
   mattr_accessor :urls_expire_in
 
   mattr_accessor :routes_prefix, default: "/rails/active_storage"

activestorage/lib/active_storage/engine.rb

@@ -110,6 +110,7 @@ class Engine < Rails::Engine # :nodoc:
         ActiveStorage.variable_content_types = app.config.active_storage.variable_content_types || []
         ActiveStorage.web_image_content_types = app.config.active_storage.web_image_content_types || []
         ActiveStorage.content_types_to_serve_as_binary = app.config.active_storage.content_types_to_serve_as_binary || []
+        ActiveStorage.touch_attachment_records = app.config.active_storage.touch_attachment_records != false
         ActiveStorage.service_urls_expire_in = app.config.active_storage.service_urls_expire_in || 5.minutes
         ActiveStorage.urls_expire_in = app.config.active_storage.urls_expire_in
         ActiveStorage.content_types_allowed_inline = app.config.active_storage.content_types_allowed_inline || []

activestorage/test/engine_test.rb

@@ -25,4 +25,8 @@ class ActiveStorage::EngineTest < ActiveSupport::TestCase
   test "image/bmp is a default content type" do
     assert_includes ActiveStorage.variable_content_types, "image/bmp"
   end
+
+  test "true is the default touch_attachment_records value" do
+    assert_equal true, ActiveStorage.touch_attachment_records
+  end
 end

guides/source/configuring.md

@@ -2848,6 +2848,10 @@ The default is 5 minutes.
 
 Determines the default expiry of URLs in the Rails application generated by Active Storage. The default is nil.
 
+#### `config.active_storage.touch_attachment_records`
+
+Directs ActiveStorage::Attachments to touch its corresponding record when updated. The default is true.
+
 #### `config.active_storage.routes_prefix`
 
 Can be used to set the route prefix for the routes served by Active Storage. Accepts a string that will be prepended to the generated routes.