Remove deprecated name argument from ActiveRecord::Base.remove_connection

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated `name` argument from `ActiveRecord::Base.remove_connection`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated support to call `alias_attribute` with non-existent attribute names.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/connection_handling.rb

@@ -299,16 +299,9 @@ def connected?
       connection_handler.connected?(connection_specification_name, role: current_role, shard: current_shard)
     end
 
-    def remove_connection(name = nil)
-      if name
-        ActiveRecord.deprecator.warn(<<-MSG.squish)
-          The name argument for `#remove_connection` is deprecated without replacement
-          and will be removed in Rails 7.2. `#remove_connection` should always be called
-          on the connection class directly, which makes the name argument obsolete.
-        MSG
-      end
+    def remove_connection
+      name = @connection_specification_name if defined?(@connection_specification_name)
 
-      name ||= @connection_specification_name if defined?(@connection_specification_name)
       # if removing a connection that has a pool, we reset the
       # connection_specification_name so it will use the parent
       # pool.

activerecord/test/cases/connection_adapters/connection_handler_test.rb

@@ -293,22 +293,6 @@ def test_a_class_using_custom_pool_and_switching_back_to_primary
         assert_same klass2.connection, ActiveRecord::Base.connection
       end
 
-      def test_remove_connection_with_name_argument_is_deprecated
-        klass2 = Class.new(Base) { def self.name; "klass2"; end }
-
-        assert_same klass2.connection, ActiveRecord::Base.connection
-
-        pool = klass2.establish_connection(ActiveRecord::Base.connection_pool.db_config.configuration_hash)
-        assert_same klass2.connection, pool.connection
-        assert_not_same klass2.connection, ActiveRecord::Base.connection
-
-        assert_deprecated(ActiveRecord.deprecator) do
-          ActiveRecord::Base.remove_connection("klass2")
-        end
-      ensure
-        ActiveRecord::Base.establish_connection :arunit
-      end
-
       class ApplicationRecord < ActiveRecord::Base
         self.abstract_class = true
       end

guides/source/7_2_release_notes.md

@@ -109,6 +109,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
 
 *   Remove deprecated support to call `alias_attribute` with non-existent attribute names.
 
+*   Remove deprecated `name` argument from `ActiveRecord::Base.remove_connection`.
+
 ### Deprecations
 
 ### Notable changes