Merge pull request rails#53855 from rails/rm-transaction-open

Change the internal transaction state to be closed when the transaction is finalized

Author: rafaelfranca

activerecord/lib/active_record.rb

@@ -550,7 +550,7 @@ def self.all_open_transactions # :nodoc:
       if active_connection = pool.active_connection
         current_transaction = active_connection.current_transaction
 
-        if current_transaction.open? && current_transaction.joinable? && !current_transaction.state.invalidated?
+        if current_transaction.open? && current_transaction.joinable?
           open_transactions << current_transaction
         end
       end

activerecord/lib/active_record/connection_adapters/abstract/transaction.rb

@@ -175,11 +175,11 @@ def dirty?
       end
 
       def open?
-        true
+        !closed?
       end
 
       def closed?
-        false
+        @state.finalized?
       end
 
       def add_record(record, ensure_finalize = true)

activerecord/lib/active_record/transaction.rb

@@ -112,7 +112,7 @@ def open?
 
     # Returns true if the transaction doesn't exist or is finalized.
     def closed?
-      @internal_transaction.nil? || @internal_transaction.state.finalized?
+      @internal_transaction.nil? || @internal_transaction.closed?
     end
 
     alias_method :blank?, :closed?