Skip to content

Commit 7e06191

Browse files
authored
Merge pull request rails#53879 from aidanharan/skip-unless-upsert-all-support
Add missing `supports_insert_on_duplicate_update?` checks to some tests
2 parents 9716747 + 7813fb5 commit 7e06191

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

activerecord/test/cases/insert_all_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -770,6 +770,8 @@ def test_upsert_all_on_relation_precedence
770770
end
771771

772772
def test_upsert_all_resets_relation
773+
skip unless supports_insert_on_duplicate_update?
774+
773775
audit_logs = Developer.create!(name: "Alice").audit_logs.load
774776

775777
assert_changes "audit_logs.loaded?", from: true, to: false do
@@ -786,6 +788,8 @@ def test_upsert_all_create_with
786788
end
787789

788790
def test_upsert_all_has_many_through
791+
skip unless supports_insert_on_duplicate_update?
792+
789793
book = Book.first
790794
assert_raise(ArgumentError) { book.subscribers.upsert_all([ { nick: "Jimmy" } ]) }
791795
end

0 commit comments

Comments
 (0)