Merge pull request rails#54185 from seanpdoyle/active-storage-filename-equality

Delegate `ActiveStorage::Filename#to_str` to `#to_s`

Author: rafaelfranca

activestorage/CHANGELOG.md

@@ -1,3 +1,16 @@
+*   Delegate `ActiveStorage::Filename#to_str` to `#to_s`
+
+    Supports checking String equality:
+
+    ```ruby
+    filename = ActiveStorage::Filename.new("file.txt")
+    filename == "file.txt" # => true
+    filename in "file.txt" # => true
+    "file.txt" == filename # => true
+    ```
+
+    *Sean Doyle*
+
 *   Add support for alternative MD5 implementation through `config.active_storage.checksum_implementation`.
 
     Also automatically degrade to using the slower `Digest::MD5` implementation if `OpenSSL::Digest::MD5`

activestorage/app/models/active_storage/filename.rb

@@ -64,6 +64,7 @@ def sanitized
   def to_s
     sanitized.to_s
   end
+  alias_method :to_str, :to_s
 
   def as_json(*)
     to_s

activestorage/test/models/filename_test.rb

@@ -54,6 +54,12 @@ class ActiveStorage::FilenameTest < ActiveSupport::TestCase
     assert_operator ActiveStorage::Filename.new("foo-bar.pdf"), :==, ActiveStorage::Filename.new("foo\tbar.pdf")
   end
 
+  test "String equality" do
+    assert_operator "foo-bar.pdf", :===, ActiveStorage::Filename.new("foo-bar.pdf")
+    assert_equal "foo-bar.pdf", ActiveStorage::Filename.new("foo-bar.pdf")
+    assert_pattern { ActiveStorage::Filename.new("foo-bar.pdf") => "foo-bar.pdf" }
+  end
+
   test "encoding to json" do
     assert_equal '"foo.pdf"', ActiveStorage::Filename.new("foo.pdf").to_json
     assert_equal '{"filename":"foo.pdf"}', { filename: ActiveStorage::Filename.new("foo.pdf") }.to_json