Remove deprecated support to passing coder and class as second argument to serialize

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated support to passing coder and class as second argument to `serialize`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated support to `ActiveRecord::Base#read_attribute(:id)` to return the custom primary key value.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/attribute_methods/serialization.rb

@@ -180,29 +180,7 @@ module ClassMethods
         #     serialize :preferences, coder: Rot13JSON
         #   end
         #
-        def serialize(attr_name, class_name_or_coder = nil, coder: nil, type: Object, yaml: {}, **options)
-          unless class_name_or_coder.nil?
-            if class_name_or_coder == ::JSON || [:load, :dump].all? { |x| class_name_or_coder.respond_to?(x) }
-              ActiveRecord.deprecator.warn(<<~MSG)
-                Passing the coder as positional argument is deprecated and will be removed in Rails 7.2.
-
-                Please pass the coder as a keyword argument:
-
-                  serialize #{attr_name.inspect}, coder: #{class_name_or_coder}
-              MSG
-              coder = class_name_or_coder
-            else
-              ActiveRecord.deprecator.warn(<<~MSG)
-                Passing the class as positional argument is deprecated and will be removed in Rails 7.2.
-
-                Please pass the class as a keyword argument:
-
-                  serialize #{attr_name.inspect}, type: #{class_name_or_coder.name}
-              MSG
-              type = class_name_or_coder
-            end
-          end
-
+        def serialize(attr_name, coder: nil, type: Object, yaml: {}, **options)
           coder ||= default_column_serializer
           unless coder
             raise ArgumentError, <<~MSG.squish

activerecord/test/cases/serialized_attribute_test.rb

@@ -693,26 +693,4 @@ def test_supports_permitted_classes_for_default_column_serializer
     topic = Topic.new(content: Time.now)
     assert topic.save
   end
-
-  def test_recognizes_coder_as_deprecated_positional_argument
-    some_coder = Struct.new(:foo) do
-      def self.dump(value)
-        value.foo
-      end
-
-      def self.load(value)
-        new(value)
-      end
-    end
-
-    assert_deprecated(/Please pass the coder as a keyword argument/, ActiveRecord.deprecator) do
-      Topic.serialize(:content, some_coder)
-    end
-  end
-
-  def test_recognizes_type_as_deprecated_positional_argument
-    assert_deprecated(/Please pass the class as a keyword argument/, ActiveRecord.deprecator) do
-      Topic.serialize(:content, Hash)
-    end
-  end
 end

guides/source/7_2_release_notes.md

@@ -140,6 +140,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
 
 *   Remove deprecated support to `ActiveRecord::Base#read_attribute(:id)` to return the custom primary key value.
 
+*   Remove deprecated support to passing coder and class as second argument to `serialize`.
+
 ### Deprecations
 
 *   Deprecate `Rails.application.config.active_record.allow_deprecated_singular_associations_name`