Skip to content

Commit 832fb1d

Browse files
authored
Merge pull request rails#49454 from Shopify/jruby-skip
2 parents 7d58fe9 + 02e679b commit 832fb1d

File tree

7 files changed

+1
-39
lines changed

7 files changed

+1
-39
lines changed

actionmailer/test/abstract_unit.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ def self.root
3838

3939
class ActiveSupport::TestCase
4040
include ActiveSupport::Testing::MethodCallAssertions
41-
42-
private
43-
# Skips the current run on JRuby using Minitest::Assertions#skip
44-
def jruby_skip(message = "")
45-
skip message if defined?(JRUBY_VERSION)
46-
end
4741
end
4842

4943
require_relative "../../tools/test_common"

actionpack/test/abstract_unit.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -362,12 +362,6 @@ class ImagesController < ResourcesController; end
362362

363363
class ActiveSupport::TestCase
364364
include ActiveSupport::Testing::MethodCallAssertions
365-
366-
private
367-
# Skips the current run on JRuby using Minitest::Assertions#skip
368-
def jruby_skip(message = "")
369-
skip message if defined?(JRUBY_VERSION)
370-
end
371365
end
372366

373367
module CookieAssertions

actionview/test/abstract_unit.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -186,12 +186,6 @@ class ActiveSupport::TestCase
186186
end
187187

188188
include ActiveSupport::Testing::MethodCallAssertions
189-
190-
private
191-
# Skips the current run on JRuby using Minitest::Assertions#skip
192-
def jruby_skip(message = "")
193-
skip message if defined?(JRUBY_VERSION)
194-
end
195189
end
196190

197191
require_relative "../../tools/test_common"

actionview/test/template/date_helper_test.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,7 @@ def test_distance_in_words_with_mixed_argument_types
144144
end
145145

146146
def test_distance_in_words_doesnt_use_the_quotient_operator
147-
jruby_skip "Date is written in Ruby and relies on Integer#/"
148-
149-
# Make sure that we avoid Integer#/ (redefined by mathn)
147+
# Make sure that we avoid Integer#/ (redefined by mathn gem to return Rational)
150148
Integer.send :private, :/
151149

152150
from = Time.utc(2004, 6, 6, 21, 45, 0)

activemodel/test/cases/helper.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ def after_teardown
2323

2424
raise AssertionlessTest, "No assertions made." if passed? && assertions.zero?
2525
end
26-
27-
private
28-
# Skips the current run on JRuby using Minitest::Assertions#skip
29-
def jruby_skip(message = "")
30-
skip message if defined?(JRUBY_VERSION)
31-
end
3226
end
3327

3428
require_relative "../../../tools/test_common"

activesupport/test/abstract_unit.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@ class ActiveSupport::TestCase
4343

4444
include ActiveSupport::Testing::MethodCallAssertions
4545
include ActiveSupport::Testing::ErrorReporterAssertions
46-
47-
private
48-
# Skips the current run on JRuby using Minitest::Assertions#skip
49-
def jruby_skip(message = "")
50-
skip message if defined?(JRUBY_VERSION)
51-
end
5246
end
5347

5448
require_relative "../../tools/test_common"

railties/test/abstract_unit.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@ class Application < Rails::Application
2222

2323
class ActiveSupport::TestCase
2424
include ActiveSupport::Testing::Stream
25-
26-
private
27-
# Skips the current run on JRuby using Minitest::Assertions#skip
28-
def jruby_skip(message = "")
29-
skip message if defined?(JRUBY_VERSION)
30-
end
3125
end
3226

3327
require_relative "../../tools/test_common"

0 commit comments

Comments
 (0)