Merge pull request rails#51585 from Shopify/create-fixtures-block

TestCase#create_fixtures no longer takes a block

Author: byroot

activerecord/test/cases/fixtures_test.rb

@@ -374,7 +374,7 @@ def test_multiple_clean_fixtures
   end
 
   def test_create_symbol_fixtures
-    fixtures = ActiveRecord::FixtureSet.create_fixtures(FIXTURES_ROOT, :collections, collections: Course) { Course.connection }
+    fixtures = ActiveRecord::FixtureSet.create_fixtures(FIXTURES_ROOT, :collections, collections: Course)
 
     assert Course.find_by_name("Collection"), "course is not in the database"
     assert fixtures.detect { |f| f.name == "collections" }, "no fixtures named 'collections' in #{fixtures.map(&:name).inspect}"

activerecord/test/cases/multiple_db_test.rb

@@ -9,8 +9,8 @@ class MultipleDbTest < ActiveRecord::TestCase
   self.use_transactional_tests = false
 
   def setup
-    @courses  = create_fixtures("courses") { Course.retrieve_connection }
-    @colleges = create_fixtures("colleges") { College.retrieve_connection }
+    @courses  = create_fixtures("courses")
+    @colleges = create_fixtures("colleges")
     @entrants = create_fixtures("entrants")
   end
 

activerecord/test/cases/test_case.rb

@@ -83,8 +83,8 @@ def check_connection_leaks
       end
     end
 
-    def create_fixtures(*fixture_set_names, &block)
-      ActiveRecord::FixtureSet.create_fixtures(ActiveRecord::TestCase.fixture_paths, fixture_set_names, fixture_class_names, &block)
+    def create_fixtures(*fixture_set_names)
+      ActiveRecord::FixtureSet.create_fixtures(ActiveRecord::TestCase.fixture_paths, fixture_set_names, fixture_class_names)
     end
 
     def capture_sql(include_schema: false)