Merge pull request rails#50054 from Shopify/deprecator-thread-each-caller

Formally deprecate passing `caller` to `Deprecation#warn`

Author: byroot

activesupport/lib/active_support/deprecation/reporting.rb

@@ -151,7 +151,12 @@ def extract_callstack(callstack)
         end
 
         def _extract_callstack(callstack)
-          warn "Please pass `caller_locations` to the deprecation API" if $VERBOSE
+          ActiveSupport.deprecator.warn(<<~MESSAGE)
+            Passing the result of `caller` to ActiveSupport::Deprecation#warn is deprecated and will be removed in Rails 7.2.
+
+            Please pass the result of `caller_locations` instead.
+          MESSAGE
+
           offending_line = callstack.find { |line| !ignored_callstack?(line) } || callstack.first
 
           if offending_line

activesupport/test/deprecation_test.rb

@@ -39,6 +39,14 @@ def setup
     end
   end
 
+  test "passing callstack as `caller` is deprecated" do
+    assert_deprecated(/Passing the result of `caller` to ActiveSupport::Deprecation#warn/, ActiveSupport.deprecator) do
+      assert_deprecated(@deprecator) do
+        @deprecator.warn("Yo dawg!", caller)
+      end
+    end
+  end
+
   test "assert_deprecated is deprecated without a deprecator" do
     assert_deprecated(ActiveSupport.deprecator) do
       assert_deprecated do