Remove deprecated support to quote ActiveSupport::Duration

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated support to quote `ActiveSupport::Duration`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated `#quote_bound_value`.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/connection_adapters/abstract/quoting.rb

@@ -23,9 +23,6 @@ def quote(value)
         when Type::Time::Value then "'#{quoted_time(value)}'"
         when Date, Time then "'#{quoted_date(value)}'"
         when Class      then "'#{value}'"
-        when ActiveSupport::Duration
-          warn_quote_duration_deprecated
-          value.to_s
         else raise TypeError, "can't quote #{value.class.name}"
         end
       end
@@ -229,22 +226,6 @@ def type_casted_binds(binds)
         def lookup_cast_type(sql_type)
           type_map.lookup(sql_type)
         end
-
-        def warn_quote_duration_deprecated
-          ActiveRecord.deprecator.warn(<<~MSG)
-            Using ActiveSupport::Duration as an interpolated bind parameter in an SQL
-            string template is deprecated. To avoid this warning, you should explicitly
-            convert the duration to a more specific database type. For example, if you
-            want to use a duration as an integer number of seconds:
-            ```
-            Record.where("duration = ?", 1.hour.to_i)
-            ```
-            If you want to use a duration as an ISO 8601 string:
-            ```
-            Record.where("duration = ?", 1.hour.iso8601)
-            ```
-          MSG
-        end
     end
   end
 end

activerecord/test/cases/adapters/abstract_mysql_adapter/bind_parameter_test.rb

@@ -72,12 +72,6 @@ def test_where_with_rational_for_string_column_using_bind_parameters
           assert_quoted_as "'0.0'", Rational(0)
         end
 
-        def test_where_with_duration_for_string_column_using_bind_parameters
-          assert_deprecated(ActiveRecord.deprecator) do
-            assert_quoted_as "'0'", 0.seconds
-          end
-        end
-
         private
           def assert_quoted_as(expected, value)
             relation = Post.where("title = ?", value)

activerecord/test/cases/adapters/postgresql/bind_parameter_test.rb

@@ -33,12 +33,6 @@ def test_where_with_rational_for_string_column_using_bind_parameters
           assert_quoted_as "0/1", Rational(0), valid: false
         end
 
-        def test_where_with_duration_for_string_column_using_bind_parameters
-          assert_deprecated(ActiveRecord.deprecator) do
-            assert_quoted_as "0", 0.seconds, valid: false
-          end
-        end
-
         private
           def assert_quoted_as(expected, value, valid: true)
             relation = Post.where("title = ?", value)

activerecord/test/cases/adapters/sqlite3/bind_parameter_test.rb

@@ -33,12 +33,6 @@ def test_where_with_rational_for_string_column_using_bind_parameters
           assert_quoted_as "0/1", Rational(0)
         end
 
-        def test_where_with_duration_for_string_column_using_bind_parameters
-          assert_deprecated(ActiveRecord.deprecator) do
-            assert_quoted_as "0", 0.seconds
-          end
-        end
-
         private
           def assert_quoted_as(expected, value)
             relation = Post.where("title = ?", value)

activerecord/test/cases/quoting_test.rb

@@ -191,8 +191,8 @@ def test_quote_as_mb_chars_no_column
       end
 
       def test_quote_duration
-        expected = assert_deprecated(ActiveRecord.deprecator) { @quoter.quote(30.minutes) }
-        assert_equal "1800", expected
+        exception = assert_raises(TypeError) { @quoter.quote(30.minutes) }
+        assert_equal "can't quote ActiveSupport::Duration", exception.message
       end
     end
 

guides/source/7_2_release_notes.md

@@ -158,6 +158,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
 
 *   Remove deprecated `#quote_bound_value`.
 
+*   Remove deprecated support to quote `ActiveSupport::Duration`.
+
 ### Deprecations
 
 *   Deprecate `Rails.application.config.active_record.allow_deprecated_singular_associations_name`