Merge pull request rails#50336 from fatkodima/schema_dumper-dump-global-out

Change `SchemaDumper.dump` default stream to `$stdout`

Author: byroot

activerecord/lib/active_record/schema_dumper.rb

@@ -41,7 +41,7 @@ class SchemaDumper # :nodoc:
     cattr_accessor :unique_ignore_pattern, default: /^uniq_rails_[0-9a-f]{10}$/
 
     class << self
-      def dump(connection = ActiveRecord::Base.connection, stream = STDOUT, config = ActiveRecord::Base)
+      def dump(connection = ActiveRecord::Base.connection, stream = $stdout, config = ActiveRecord::Base)
         connection.create_schema_dumper(generate_options(config)).dump(stream)
         stream
       end

activerecord/test/support/schema_dumping_helper.rb

@@ -5,19 +5,21 @@ def dump_table_schema(*tables)
     connection = ActiveRecord::Base.connection
     old_ignore_tables = ActiveRecord::SchemaDumper.ignore_tables
     ActiveRecord::SchemaDumper.ignore_tables = connection.data_sources - tables
-    stream = StringIO.new
 
-    ActiveRecord::SchemaDumper.dump(connection, stream)
-    stream.string
+    output, = capture_io do
+      ActiveRecord::SchemaDumper.dump(connection)
+    end
+    output
   ensure
     ActiveRecord::SchemaDumper.ignore_tables = old_ignore_tables
   end
 
   def dump_all_table_schema(ignore_tables = [], connection: ActiveRecord::Base.connection)
     old_ignore_tables, ActiveRecord::SchemaDumper.ignore_tables = ActiveRecord::SchemaDumper.ignore_tables, ignore_tables
-    stream = StringIO.new
-    ActiveRecord::SchemaDumper.dump(connection, stream)
-    stream.string
+    output, = capture_io do
+      ActiveRecord::SchemaDumper.dump(connection)
+    end
+    output
   ensure
     ActiveRecord::SchemaDumper.ignore_tables = old_ignore_tables
   end