Skip to content

Commit 9928479

Browse files
committed
Fix devcontainer smoke test for forked repos
When we run the smoke test on main, we push the devcontainer images to ghcr to be used as a cache for future workflow runs. This causes an error on forks because they don't have permission to push (which is good). So, let's set the step to never push if the repo is a fork. The github context doesn't have a way of checking if the repo is a fork, so I check the repo owner instead, but that's ok since it's the repo owner (rails) who has permissions to push the package.
1 parent 778039b commit 9928479

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/devcontainer-smoke-test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,5 +46,6 @@ jobs:
4646
imageName: ghcr.io/rails/smoke-test-devcontainer
4747
cacheFrom: ghcr.io/rails/smoke-test-devcontainer
4848
imageTag: ${{ matrix.DATABASE }}
49+
push: ${{ github.repository_owner == 'rails' && 'filter' || 'never' }}
4950
refFilterForPush: refs/heads/main
5051
runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test

0 commit comments

Comments
 (0)