Merge pull request rails#49644 from kyoshidajp/migration_generator_exit_failure_non_zero

Non-zero exit status on migration file creation errors

Author: byroot

railties/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Exit with non-zero status when the migration generator fails.
+
+    *Katsuhiko YOSHIDA*
+
 *   Use numeric UID and GID in Dockerfile template
 
     The Dockerfile generated by `rails new` sets the default user and group

railties/lib/rails/generators/rails/migration/migration_generator.rb

@@ -5,6 +5,10 @@ module Generators
     class MigrationGenerator < NamedBase # :nodoc:
       argument :attributes, type: :array, default: [], banner: "field[:type][:index] field[:type][:index]"
       hook_for :orm, required: true, desc: "ORM to be invoked"
+
+      def self.exit_on_failure? # :nodoc:
+        true
+      end
     end
   end
 end

railties/test/generators/migration_generator_test.rb

@@ -49,6 +49,10 @@ def test_migration_with_invalid_file_name
     end
   end
 
+  def test_exit_on_failure
+    assert_equal true, generator_class.exit_on_failure?
+  end
+
   def test_add_migration_with_attributes
     migration = "add_title_body_to_posts"
     run_generator [migration, "title:string", "body:text"]