Merge pull request rails#48139 from OuYangJinTing/fix/activerecord_insert_all

Fix active record insert values of type cast and serialize

Author: kamipo

activerecord/lib/active_record/insert_all.rb

@@ -240,7 +240,7 @@ def values_list
 
           values_list = insert_all.map_key_with_value do |key, value|
             next value if Arel::Nodes::SqlLiteral === value
-            connection.with_yaml_fallback(types[key].serialize(value))
+            types[key].serialize(types[key].cast(value))
           end
 
           connection.visitor.compile(Arel::Nodes::ValuesList.new(values_list))

activerecord/test/cases/insert_all_test.rb

@@ -47,6 +47,17 @@ def test_insert!
     end
   end
 
+  def test_insert_with_type_casting_and_serialize_is_consistent
+    skip unless supports_insert_returning?
+
+    book_name = ["Array"]
+    created_book_id = Book.create!(name: book_name).id
+    inserted_book_id = Book.insert!({ name: book_name }, returning: :id).first["id"]
+    raw_created_book_name = Book.connection.select_value(Book.select(:name).where(id: created_book_id))
+    raw_inserted_book_name = Book.connection.select_value(Book.select(:name).where(id: inserted_book_id))
+    assert_equal raw_created_book_name, raw_inserted_book_name
+  end
+
   def test_insert_all
     assert_difference "Book.count", +10 do
       Book.insert_all! [