Skip to content

Commit 9af3004

Browse files
authored
Merge pull request rails#53976 from aidanharan/arel-tests-without-assertions
Updated Arel spec tests to check for assertionless tests
2 parents 17d8cd4 + b884df5 commit 9af3004

21 files changed

+840
-837
lines changed

activerecord/test/cases/arel/attributes_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
require_relative "helper"
44

55
module Arel
6-
describe "Attributes" do
6+
class AttributesTest < Arel::Spec
77
it "responds to lower" do
88
relation = Table.new(:users)
99
attribute = relation[:foo]

activerecord/test/cases/arel/crud_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def initialize(engine = FakeEngine.new)
3131
end
3232
end
3333

34-
describe "crud" do
34+
class CrudTest < Arel::Spec
3535
describe "insert" do
3636
it "should call insert on the connection" do
3737
table = Table.new :users

activerecord/test/cases/arel/helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ class Spec < Minitest::Spec
3636
Arel::Table.engine = @arel_engine if defined? @arel_engine
3737
end
3838
include ActiveSupport::Testing::Assertions
39+
include ActiveSupport::Testing::TestsWithoutAssertions
3940

4041
# test/unit backwards compatibility methods
4142
alias :assert_no_match :refute_match

activerecord/test/cases/arel/nodes/and_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module Arel
66
module Nodes
7-
describe "And" do
7+
class AndTest < Arel::Spec
88
describe "equality" do
99
it "is equal with equal ivars" do
1010
array = [And.new(["foo", "bar"]), And.new(["foo", "bar"])]

activerecord/test/cases/arel/nodes/as_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module Arel
66
module Nodes
7-
describe "As" do
7+
class AsTest < Arel::Spec
88
describe "#as" do
99
it "makes an AS node" do
1010
attr = Table.new(:users)[:id]

activerecord/test/cases/arel/nodes/bind_param_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module Arel
66
module Nodes
7-
describe "BindParam" do
7+
class BindParamTest < Arel::Spec
88
it "is equal to other bind params with the same value" do
99
_(BindParam.new(1)).must_equal(BindParam.new(1))
1010
_(BindParam.new("foo")).must_equal(BindParam.new("foo"))

activerecord/test/cases/arel/nodes/casted_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module Arel
66
module Nodes
7-
describe Casted do
7+
class CastedTest < Arel::Spec
88
describe "#hash" do
99
it "is equal when eql? returns true" do
1010
one = Casted.new 1, 2

activerecord/test/cases/arel/nodes/cte_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module Arel
66
module Nodes
7-
describe "Cte" do
7+
class CteTest < Arel::Spec
88
describe "equality" do
99
it "is equal with equal ivars" do
1010
array = [

activerecord/test/cases/arel/nodes/delete_statement_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require_relative "../helper"
44

5-
describe Arel::Nodes::DeleteStatement do
5+
class Arel::Nodes::DeleteStatementTest < Arel::Spec
66
describe "#clone" do
77
it "clones wheres" do
88
statement = Arel::Nodes::DeleteStatement.new

activerecord/test/cases/arel/nodes/distinct_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
module Arel
66
module Nodes
7-
describe "Distinct" do
7+
class DistinctTest < Arel::Spec
88
describe "equality" do
99
it "is equal to other distinct nodes" do
1010
array = [Distinct.new, Distinct.new]

0 commit comments

Comments
 (0)