Skip to content

Commit 9d9969f

Browse files
ghiculescuzzak
andcommitted
Fix the turbolinks npm -> github reference
Bug in rails#42263 You can replicate this by doing `rails new --main` with that PR. This now uses the correct github reference, per the [npm docs](https://docs.npmjs.com/cli/v7/configuring-npm/package-json#github-urls). Co-authored-by: Zachary Scott <[email protected]>
1 parent d6a1cff commit 9d9969f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

railties/lib/rails/generators/app_base.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ def turbolinks_npm_version
326326
# since Turbolinks is deprecated, let's just always point to main.
327327
# expect this to be replaced with Hotwire at some point soon.
328328
if options.main? || options.edge?
329-
"git://github.com/turbolinks/turbolinks.git#main"
329+
"turbolinks/turbolinks#master"
330330
else
331331
"^5.2.0"
332332
end

railties/test/generators/app_generator_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ def test_package_json_uses_edge_versions
551551
assert_match(/"@rails\/ujs": "latest"/, content)
552552
assert_match(/"@rails\/activestorage": "latest"/, content)
553553
assert_match(/"@rails\/actioncable": "latest"/, content)
554-
assert_match(/"turbolinks": "git:\/\/github.com\/turbolinks\/turbolinks.git#main"/, content)
554+
assert_match(/"turbolinks": "turbolinks\/turbolinks#master"/, content)
555555
end
556556
end
557557

0 commit comments

Comments
 (0)