Remove deprecated support to passing SchemaMigration and InternalMetadata classes as arguments to ActiveRecord::MigrationContext.

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,8 @@
+*   Remove deprecated support to passing `SchemaMigration` and `InternalMetadata` classes as arguments to
+    `ActiveRecord::MigrationContext`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated `ActiveRecord::Migration.check_pending` method.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/migration.rb

@@ -1205,28 +1205,6 @@ class MigrationContext
     attr_reader :migrations_paths, :schema_migration, :internal_metadata
 
     def initialize(migrations_paths, schema_migration = nil, internal_metadata = nil)
-      if schema_migration == SchemaMigration
-        ActiveRecord.deprecator.warn(<<-MSG.squish)
-          SchemaMigration no longer inherits from ActiveRecord::Base. If you want
-          to use the default connection, remove this argument. If you want to use a
-          specific connection, instantiate MigrationContext with the connection's schema
-          migration, for example `MigrationContext.new(path, Dog.connection.schema_migration)`.
-        MSG
-
-        schema_migration = nil
-      end
-
-      if internal_metadata == InternalMetadata
-        ActiveRecord.deprecator.warn(<<-MSG.squish)
-          SchemaMigration no longer inherits from ActiveRecord::Base. If you want
-          to use the default connection, remove this argument. If you want to use a
-          specific connection, instantiate MigrationContext with the connection's internal
-          metadata, for example `MigrationContext.new(path, nil, Dog.connection.internal_metadata)`.
-        MSG
-
-        internal_metadata = nil
-      end
-
       @migrations_paths = migrations_paths
       @schema_migration = schema_migration || SchemaMigration.new(connection)
       @internal_metadata = internal_metadata || InternalMetadata.new(connection)

activerecord/test/cases/migration_test.rb

@@ -79,22 +79,6 @@ def setup
     ActiveRecord::Migration.verbose = @verbose_was
   end
 
-  def test_passing_a_schema_migration_class_to_migration_context_is_deprecated
-    migrations_path = MIGRATIONS_ROOT + "/valid"
-    migrator = assert_deprecated(ActiveRecord.deprecator) { ActiveRecord::MigrationContext.new(migrations_path, ActiveRecord::SchemaMigration, ActiveRecord::InternalMetadata) }
-    migrator.up
-
-    assert_equal 3, migrator.current_version
-    assert_equal false, migrator.needs_migration?
-
-    migrator.down
-    assert_equal 0, migrator.current_version
-    assert_equal true, migrator.needs_migration?
-
-    @schema_migration.create_version(3)
-    assert_equal true, migrator.needs_migration?
-  end
-
   def test_migration_context_with_default_schema_migration
     migrations_path = MIGRATIONS_ROOT + "/valid"
     migrator = ActiveRecord::MigrationContext.new(migrations_path)

guides/source/7_2_release_notes.md

@@ -131,6 +131,9 @@ Please refer to the [Changelog][active-record] for detailed changes.
 
 *   Remove deprecated `ActiveRecord::Migration.check_pending` method.
 
+*   Remove deprecated support to passing `SchemaMigration` and `InternalMetadata` classes as arguments to
+    `ActiveRecord::MigrationContext`.
+
 ### Deprecations
 
 ### Notable changes