Skip to content

Commit a45bfd9

Browse files
committed
Remove deprecated SafeBuffer#clone_empty
1 parent 4d676ec commit a45bfd9

File tree

4 files changed

+6
-22
lines changed

4 files changed

+6
-22
lines changed

activesupport/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
* Remove deprecated `SafeBuffer#clone_empty`.
2+
3+
*Rafael Mendonça França*
4+
15
* Remove deprecated `#to_default_s` from `Array`, `Date`, `DateTime` and `Time`.
26

37
*Rafael Mendonça França*

activesupport/lib/active_support/core_ext/string/output_safety.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,6 @@ def initialize_copy(other)
7777
@html_safe = other.html_safe?
7878
end
7979

80-
def clone_empty # :nodoc:
81-
ActiveSupport.deprecator.warn <<~EOM
82-
ActiveSupport::SafeBuffer#clone_empty is deprecated and will be removed in Rails 7.2.
83-
EOM
84-
self[0, 0]
85-
end
86-
8780
def concat(value)
8881
unless value.nil?
8982
super(implicit_html_escape_interpolated_argument(value))

activesupport/test/safe_buffer_test.rb

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -195,21 +195,6 @@ def test_titleize
195195
assert_kind_of NilClass, @buffer.slice("chipchop")
196196
end
197197

198-
test "clone_empty returns an empty buffer" do
199-
assert_deprecated(ActiveSupport.deprecator) do
200-
assert_equal "", ActiveSupport::SafeBuffer.new("foo").clone_empty
201-
end
202-
end
203-
204-
test "clone_empty keeps the original dirtiness" do
205-
assert_deprecated(ActiveSupport.deprecator) do
206-
assert_predicate @buffer.clone_empty, :html_safe?
207-
end
208-
assert_deprecated(ActiveSupport.deprecator) do
209-
assert_not_predicate @buffer.gsub!("", "").clone_empty, :html_safe?
210-
end
211-
end
212-
213198
test "Should be safe when sliced if original value was safe" do
214199
new_buffer = @buffer[0, 0]
215200
assert_not_nil new_buffer

guides/source/7_2_release_notes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ Please refer to the [Changelog][active-support] for detailed changes.
207207

208208
### Removals
209209

210+
* Remove deprecated `SafeBuffer#clone_empty`.
211+
210212
* Remove deprecated `#to_default_s` from `Array`, `Date`, `DateTime` and `Time`.
211213

212214
* Remove deprecated `:pool_size` and `:pool_timeout` options for the cache storage.

0 commit comments

Comments
 (0)