Merge pull request rails#47619 from p8/railties/thor-restart-task

Use Thor for built-in restart task

Author: jonathanhefner

railties/CHANGELOG.md

@@ -1,3 +1,13 @@
+*   Allow calling `bin/rails restart` outside of app directory.
+
+    The following would previously fail with a "No Rakefile found" error.
+
+    ```bash
+    blog/bin/rails restart
+    ```
+
+    *Petrik de Heus*
+
 *   Support prerelease rubies in Gemfile template if RubyGems version is 3.3.13 or higher.
 
     *Yasuo Honda*, *David Rodríguez*

railties/lib/rails/command.rb

@@ -108,11 +108,15 @@ def find_by_namespace(namespace, command_name = nil) # :nodoc:
       def root
         if defined?(ENGINE_ROOT)
           Pathname.new(ENGINE_ROOT)
-        elsif defined?(APP_PATH)
-          Pathname.new(File.expand_path("../..", APP_PATH))
+        else
+          application_root
         end
       end
 
+      def application_root # :nodoc:
+        Pathname.new(File.expand_path("../..", APP_PATH)) if defined?(APP_PATH)
+      end
+
       def printing_commands # :nodoc:
         lookup!
 

railties/lib/rails/commands/restart/restart_command.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module Rails
+  module Command
+    class RestartCommand < Base # :nodoc:
+      desc "restart", "Restart app by touching tmp/restart.txt"
+      def perform
+        require "fileutils"
+        FileUtils.mkdir_p Rails::Command.application_root.join("tmp")
+        FileUtils.touch   Rails::Command.application_root.join("tmp/restart.txt")
+      end
+    end
+  end
+end

railties/lib/rails/tasks.rb

@@ -7,7 +7,6 @@
   framework
   log
   misc
-  restart
   tmp
   yarn
   zeitwerk

railties/lib/rails/tasks/restart.rake

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "isolation/abstract_unit"
+require "rails/command"
+
+class Rails::Command::RestartTest < ActiveSupport::TestCase
+  include ActiveSupport::Testing::Isolation
+  setup :build_app
+  teardown :teardown_app
+
+  test "rails restart touches tmp/restart.txt" do
+    Dir.chdir(app_path) do
+      rails "restart"
+      assert File.exist?("tmp/restart.txt")
+
+      prev_mtime = File.mtime("tmp/restart.txt")
+      sleep(1)
+      rails "restart"
+      curr_mtime = File.mtime("tmp/restart.txt")
+      assert_not_equal prev_mtime, curr_mtime
+    end
+  end
+
+  test "rails restart should work even if tmp folder does not exist" do
+    Dir.chdir(app_path) do
+      FileUtils.remove_dir("tmp")
+      rails "restart"
+      assert File.exist?("tmp/restart.txt")
+    end
+  end
+end