Merge pull request rails#53311 from Shopify/ruby-head-silence-object-id-warning

Silence `object_id` redefinition warnings in the test suite

Author: byroot

activerecord/test/cases/transaction_callbacks_test.rb

@@ -503,7 +503,9 @@ def test_saving_a_record_with_a_belongs_to_that_specifies_touching_the_parent_sh
 
   def test_saving_two_records_that_override_object_id_should_run_after_commit_callbacks_for_both
     klass = Class.new(TopicWithCallbacks) do
-      define_method(:object_id) { 42 }
+      silence_warnings do
+        define_method(:object_id) { 42 }
+      end
     end
 
     records = [klass.new, klass.new]
@@ -521,7 +523,9 @@ def test_saving_two_records_that_override_object_id_should_run_after_commit_call
 
   def test_saving_two_records_that_override_object_id_should_run_after_rollback_callbacks_for_both
     klass = Class.new(TopicWithCallbacks) do
-      define_method(:object_id) { 42 }
+      silence_warnings do
+        define_method(:object_id) { 42 }
+      end
     end
 
     records = [klass.new, klass.new]

activesupport/lib/active_support/testing/strict_warnings.rb

@@ -17,9 +17,6 @@ class WarningError < StandardError; end
 
       # TODO: We need to decide what to do with this.
       /Status code :unprocessable_entity is deprecated/,
-
-      # Allow this warning only in the `TransactionCallbacksTest`.
-      %r{.*/rails/activerecord/test/cases/transaction_callbacks_test\.rb:\d+: warning: redefining 'object_id' may cause serious problems}
     )
 
     SUPPRESSED_WARNINGS = Regexp.union(