Skip to content

Commit abc43f0

Browse files
author
David Heinemeier Hansson
authored
Add rollup as JavaScript option (rails#43164)
1 parent abc042c commit abc43f0

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

railties/lib/rails/generators/app_base.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,10 @@ def javascript_gemfile_entry
300300
GemfileEntry.version "webpacker", "~> 6.0.0.rc.5", "Transpile app-like JavaScript. Read more: https://github.com/rails/webpacker"
301301
when "esbuild"
302302
GemfileEntry.version "esbuild-rails", "~> 0.1.2", "Transpile app-like JavaScript. Read more: https://github.com/rails/esbuild-rails"
303+
when "rollup"
304+
GemfileEntry.version "rollupjs-rails", "~> 0.1.0", "Transpile app-like JavaScript. Read more: https://github.com/rails/rollupjs-rails"
303305
else
304-
raise "Unknown JavaScript approach: #{options[:javascript]}"
306+
raise "Unknown JavaScript approach: #{options[:javascript]} [options are: importmap, webpack, esbuild, rollup]"
305307
end
306308
end
307309

@@ -382,6 +384,7 @@ def run_javascript
382384
when "importmap" then rails_command "importmap:install"
383385
when "webpack" then rails_command "webpacker:install"
384386
when "esbuild" then rails_command "esbuild:install"
387+
when "rollup" then rails_command "rollup:install"
385388
end
386389
end
387390

railties/lib/rails/generators/rails/app/app_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ class AppGenerator < AppBase
270270
class_option :version, type: :boolean, aliases: "-v", group: :rails, desc: "Show Rails version number and quit"
271271
class_option :api, type: :boolean, desc: "Preconfigure smaller stack for API only apps"
272272
class_option :minimal, type: :boolean, desc: "Preconfigure a minimal rails app"
273-
class_option :javascript, type: :string, aliases: "-j", default: "importmap", desc: "Choose JavaScript approach"
273+
class_option :javascript, type: :string, aliases: "-j", default: "importmap", desc: "Choose JavaScript approach [options: importmap (default), webpack, esbuild, rollup]"
274274
class_option :skip_bundle, type: :boolean, aliases: "-B", default: false, desc: "Don't run bundle install"
275275

276276
def initialize(*args)

0 commit comments

Comments
 (0)