Merge pull request rails#51564 from fatkodima/fix-ids-sql-example

kamipo · web-flow · commit adfeb791c13c · 2024-04-14T22:06:42.000+09:00
Fix SQL query example in `ActiveRecord::Base#ids` docs [skip ci]
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
@@ -363,7 +363,7 @@ def async_pick(*column_names)
     # Returns the base model's ID's for the relation using the table's primary key
     #
     #   Person.ids # SELECT people.id FROM people
-    #   Person.joins(:companies).ids # SELECT people.id FROM people INNER JOIN companies ON companies.id = people.company_id
+    #   Person.joins(:company).ids # SELECT people.id FROM people INNER JOIN companies ON companies.id = people.company_id
     def ids
       primary_key_array = Array(primary_key)
 

Original file line number	Diff line number	Diff line change
`@@ -363,7 +363,7 @@ def async_pick(*column_names)`
`363`	`363`	`# Returns the base model's ID's for the relation using the table's primary key`
`364`	`364`	`#`
`365`	`365`	`# Person.ids # SELECT people.id FROM people`
`366`		`- # Person.joins(:companies).ids # SELECT people.id FROM people INNER JOIN companies ON companies.id = people.company_id`
	`366`	`+ # Person.joins(:company).ids # SELECT people.id FROM people INNER JOIN companies ON companies.id = people.company_id`
`367`	`367`	`def ids`
`368`	`368`	`primary_key_array = Array(primary_key)`
`369`	`369`