Skip RedisCacheStore test if no Redis server is running

MemCacheStore tests have been doing the same for a while.

As an extra safety, if `ENV["CI"]` is set, we always run
the tests.

Author: byroot

activesupport/test/cache/stores/mem_cache_store_test.rb

@@ -25,15 +25,19 @@ def alive?
     end
   end
 
-  begin
-    servers = ENV["MEMCACHE_SERVERS"] || "localhost:11211"
-    ss = Dalli::Client.new(servers).stats
-    raise Dalli::DalliError unless ss[servers] || ss[servers + ":11211"]
-
+  if ENV["CI"]
     MEMCACHE_UP = true
-  rescue Dalli::DalliError
-    $stderr.puts "Skipping memcached tests. Start memcached and try again."
-    MEMCACHE_UP = false
+  else
+    begin
+      servers = ENV["MEMCACHE_SERVERS"] || "localhost:11211"
+      ss = Dalli::Client.new(servers).stats
+      raise Dalli::DalliError unless ss[servers] || ss[servers + ":11211"]
+
+      MEMCACHE_UP = true
+    rescue Dalli::DalliError
+      $stderr.puts "Skipping memcached tests. Start memcached and try again."
+      MEMCACHE_UP = false
+    end
   end
 
   def lookup_store(options = {})

activesupport/test/cache/stores/redis_cache_store_test.rb

@@ -25,6 +25,20 @@ def get(key)
 end
 
 module ActiveSupport::Cache::RedisCacheStoreTests
+  if ENV["CI"]
+    REDIS_UP = true
+  else
+    begin
+      redis = Redis.new(url: "redis://localhost:6379/0")
+      redis.ping
+
+      REDIS_UP = true
+    rescue Redis::BaseConnectionError
+      $stderr.puts "Skipping redis tests. Start redis and try again."
+      REDIS_UP = false
+    end
+  end
+
   DRIVER = %w[ ruby hiredis ].include?(ENV["REDIS_DRIVER"]) ? ENV["REDIS_DRIVER"] : "hiredis"
 
   class LookupTest < ActiveSupport::TestCase
@@ -110,6 +124,7 @@ def build(**kwargs)
 
   class StoreTest < ActiveSupport::TestCase
     setup do
+      skip "redis server is not up" unless REDIS_UP
       @namespace = "test-#{SecureRandom.hex}"
 
       @cache = lookup_store(expires_in: 60)