Clear attachment changes on reload

Author: georgeclaghorn

activestorage/lib/active_storage/attached/model.rb

@@ -132,5 +132,9 @@ def purge_later
     def attachment_changes #:nodoc:
       @attachment_changes ||= {}
     end
+
+    def reload(*) #:nodoc:
+      super.tap { @attachment_changes = nil }
+    end
   end
 end

activestorage/test/models/attached/many_test.rb

@@ -467,6 +467,14 @@ class ActiveStorage::ManyAttachedTest < ActiveSupport::TestCase
     end
   end
 
+  test "clearing change on reload" do
+    @user.highlights = [ create_blob(filename: "funky.jpg"), create_blob(filename: "town.jpg") ]
+    assert @user.highlights.attached?
+
+    @user.reload
+    assert_not @user.highlights.attached?
+  end
+
   test "overriding attached reader" do
     @user.highlights.attach create_blob(filename: "funky.jpg"), create_blob(filename: "town.jpg")
 

activestorage/test/models/attached/one_test.rb

@@ -427,6 +427,14 @@ class ActiveStorage::OneAttachedTest < ActiveSupport::TestCase
     end
   end
 
+  test "clearing change on reload" do
+    @user.avatar = create_blob(filename: "funky.jpg")
+    assert @user.avatar.attached?
+
+    @user.reload
+    assert_not @user.avatar.attached?
+  end
+
   test "overriding attached reader" do
     @user.avatar.attach create_blob(filename: "funky.jpg")