Skip to content

Commit bfac3fc

Browse files
authored
Merge pull request rails#47939 from sirwolfgang/bugfix-actioncable
[Fix: 47938] self is undefined for actioncable
2 parents b1fd934 + f634121 commit bfac3fc

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

actioncable/app/assets/javascripts/action_cable.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

actioncable/app/assets/javascripts/actioncable.esm.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

actioncable/app/assets/javascripts/actioncable.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default {
2-
logger: self.console,
3-
WebSocket: self.WebSocket
2+
logger: typeof console !== "undefined" ? console : undefined,
3+
WebSocket: typeof WebSocket !== "undefined" ? WebSocket : undefined,
44
}

actioncable/test/javascript/src/unit/action_cable_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ const {module, test} = QUnit
66
module("ActionCable", () => {
77
module("Adapters", () => {
88
module("WebSocket", () => {
9-
test("default is self.WebSocket", assert => {
9+
test("default is WebSocket", assert => {
1010
assert.equal(ActionCable.adapters.WebSocket, self.WebSocket)
1111
})
1212
})
1313

1414
module("logger", () => {
15-
test("default is self.console", assert => {
15+
test("default is console", assert => {
1616
assert.equal(ActionCable.adapters.logger, self.console)
1717
})
1818
})

0 commit comments

Comments
 (0)