Merge pull request rails#53659 from zzak/railties-missing-assertions

Fix "Test is missing assertions" is caught by Strict Warnings

Author: kamipo

activesupport/lib/active_support/testing/tests_without_assertions.rb

@@ -11,7 +11,7 @@ def after_teardown
 
         if assertions.zero? && !skipped? && !error?
           file, line = method(name).source_location
-          warn "Test is missing assertions: `#{name}` #{file}:#{line}"
+          warn "Test is missing assertions: `#{name}` #{File.expand_path(file)}:#{line}"
         end
       end
     end

railties/test/application/generators_test.rb

@@ -188,7 +188,9 @@ def check_expected
       end
 
       quietly do
-        Rails::Command.invoke(:generate, ["check_argv", "expected"]) # should not raise
+        assert_nothing_raised do
+          Rails::Command.invoke(:generate, ["check_argv", "expected"]) # should not raise
+        end
       end
     end
 

railties/test/application/initializers/frameworks_test.rb

@@ -220,7 +220,9 @@ def show
       rails %w(generate model post title:string)
 
       with_unhealthy_database do
-        app("development")
+        assert_nothing_raised do
+          app("development")
+        end
       end
     end
 

railties/test/application/loading_test.rb

@@ -89,7 +89,9 @@ class User < ActiveRecord::Base
     require "#{rails_root}/config/environment"
     setup_ar!
 
-    User
+    assert_nothing_raised do
+      User
+    end
   end
 
   test "load config/environments/environment before Bootstrap initializers" do

railties/test/application/rake/tmp_test.rb

@@ -40,7 +40,9 @@ def teardown
 
       test "tmp:clear should work if folder missing" do
         FileUtils.remove_dir("#{app_path}/tmp")
-        rails "tmp:clear"
+        assert_nothing_raised do
+          rails "tmp:clear"
+        end
       end
     end
   end

railties/test/application/rake_test.rb

@@ -205,7 +205,9 @@ def test_loading_only_yml_fixtures
       app_file "test/fixtures/products.csv", ""
 
       require "#{rails_root}/config/environment"
-      rails "db:fixtures:load"
+      assert_nothing_raised do
+        rails "db:fixtures:load"
+      end
     end
 
     def test_scaffold_tests_pass_by_default