Remove deprecated support to passing Dalli::Client instances to MemCacheStore

Author: rafaelfranca

activesupport/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated support to passing `Dalli::Client` instances to `MemCacheStore`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated `config.active_support.use_rfc4122_namespaced_uuids`.
 
     *Rafael Mendonça França*

activesupport/lib/active_support/cache/mem_cache_store.rb

@@ -74,7 +74,6 @@ def self.build_mem_cache(*addresses) # :nodoc:
       #
       # If no addresses are provided, but <tt>ENV['MEMCACHE_SERVERS']</tt> is defined, it will be used instead. Otherwise,
       # +MemCacheStore+ will connect to localhost:11211 (the default memcached port).
-      # Passing a +Dalli::Client+ instance is deprecated and will be removed. Please pass an address instead.
       def initialize(*addresses)
         addresses = addresses.flatten
         options = addresses.extract_options!
@@ -86,19 +85,12 @@ def initialize(*addresses)
         unless [String, Dalli::Client, NilClass].include?(addresses.first.class)
           raise ArgumentError, "First argument must be an empty array, address, or array of addresses."
         end
-        if addresses.first.is_a?(Dalli::Client)
-          ActiveSupport.deprecator.warn(<<~MSG)
-            Initializing MemCacheStore with a Dalli::Client is deprecated and will be removed in Rails 7.2.
-            Use memcached server addresses instead.
-          MSG
-          @data = addresses.first
-        else
-          @mem_cache_options = options.dup
-          # The value "compress: false" prevents duplicate compression within Dalli.
-          @mem_cache_options[:compress] = false
-          (OVERRIDDEN_OPTIONS - %i(compress)).each { |name| @mem_cache_options.delete(name) }
-          @data = self.class.build_mem_cache(*(addresses + [@mem_cache_options]))
-        end
+
+        @mem_cache_options = options.dup
+        # The value "compress: false" prevents duplicate compression within Dalli.
+        @mem_cache_options[:compress] = false
+        (OVERRIDDEN_OPTIONS - %i(compress)).each { |name| @mem_cache_options.delete(name) }
+        @data = self.class.build_mem_cache(*(addresses + [@mem_cache_options]))
       end
 
       def inspect

activesupport/test/cache/cache_store_setting_test.rb

@@ -34,16 +34,6 @@ def test_mem_cache_fragment_cache_store
     end
   end
 
-  def test_mem_cache_fragment_cache_store_with_given_mem_cache
-    mem_cache = Dalli::Client.new
-    assert_not_called(Dalli::Client, :new) do
-      assert_deprecated(ActiveSupport.deprecator) do
-        store = ActiveSupport::Cache.lookup_store :mem_cache_store, mem_cache
-        assert_kind_of(ActiveSupport::Cache::MemCacheStore, store)
-      end
-    end
-  end
-
   def test_mem_cache_fragment_cache_store_with_not_dalli_client
     assert_not_called(Dalli::Client, :new) do
       memcache = Object.new

activesupport/test/cache/stores/mem_cache_store_test.rb

@@ -297,14 +297,6 @@ def test_unless_exist_expires_when_configured
     end
   end
 
-  def test_uses_provided_dalli_client_if_present
-    assert_deprecated(ActiveSupport.deprecator) do
-      host = "custom_host"
-      cache = lookup_store(Dalli::Client.new(host))
-      assert_equal [host], servers(cache)
-    end
-  end
-
   def test_forwards_string_addresses_if_present
     expected_addresses = ["first", "second"]
     cache = lookup_store(expected_addresses)

guides/source/7_2_release_notes.md

@@ -221,6 +221,8 @@ Please refer to the [Changelog][active-support] for detailed changes.
 
 *   Remove deprecated `config.active_support.use_rfc4122_namespaced_uuids`.
 
+*   Remove deprecated support to passing `Dalli::Client` instances to `MemCacheStore`.
+
 *   Remove deprecated support for the pre-Ruby 2.4 behavior of `to_time` returning a `Time` object with local timezone.
 
 ### Deprecations