Remove eager loading of schema cache dump

This will be eager loaded by the define_attribute_methods initializer
now that the schema cache can be automatically loaded for all
connection if the file is present on disk after rails#48716.

Author: rafaelfranca

activerecord/lib/active_record/railtie.rb

@@ -134,49 +134,11 @@ class Railtie < Rails::Railtie # :nodoc:
       end
     end
 
-    initializer "active_record.use_schema_cache_dump" do
-      ActiveRecord::ConnectionAdapters::SchemaReflection.use_schema_cache_dump = config.active_record.use_schema_cache_dump
-    end
-
-    initializer "active_record.check_schema_cache_dump" do
-      check_schema_cache_dump_version = config.active_record.check_schema_cache_dump_version
-
-      ActiveRecord::ConnectionAdapters::SchemaReflection.check_schema_cache_dump_version = check_schema_cache_dump_version
+    initializer "active_record.copy_schema_cache_config" do
+      active_record_config = config.active_record
 
-      if config.active_record.use_schema_cache_dump && !config.active_record.lazily_load_schema_cache
-        config.after_initialize do |app|
-          ActiveSupport.on_load(:active_record) do
-            db_config = ActiveRecord::Base.configurations.configs_for(env_name: Rails.env).first
-            next if db_config.nil?
-
-            filename = ActiveRecord::Tasks::DatabaseTasks.cache_dump_filename(db_config)
-
-            cache = ActiveRecord::ConnectionAdapters::SchemaCache._load_from(filename)
-            next if cache.nil?
-
-            if check_schema_cache_dump_version
-              current_version = begin
-                ActiveRecord::Migrator.current_version
-              rescue ActiveRecordError => error
-                warn "Failed to validate the schema cache because of #{error.class}: #{error.message}"
-                nil
-              end
-
-              if current_version.nil?
-                connection_pool.schema_reflection.clear!
-                next
-              elsif cache.schema_version != current_version
-                warn "Ignoring #{filename} because it has expired. The current schema version is #{current_version}, but the one in the schema cache file is #{cache.schema_version}."
-                connection_pool.schema_reflection.clear!
-                next
-              end
-            end
-
-            Rails.logger.info("Using schema cache file #{filename}")
-            connection_pool.schema_reflection.set_schema_cache(cache)
-          end
-        end
-      end
+      ActiveRecord::ConnectionAdapters::SchemaReflection.use_schema_cache_dump = active_record_config.use_schema_cache_dump
+      ActiveRecord::ConnectionAdapters::SchemaReflection.check_schema_cache_dump_version = active_record_config.check_schema_cache_dump_version
     end
 
     initializer "active_record.define_attribute_methods" do |app|

railties/test/application/initializers/frameworks_test.rb

@@ -232,30 +232,15 @@ def show
         config.eager_load = true
       RUBY
 
-      app("development")
+      Dir.chdir(app_path) do
+        app("development")
 
-      assert ActiveRecord::Base.connection.schema_cache.data_sources("posts")
+        assert ActiveRecord::Base.connection.schema_cache.data_sources("posts")
+      end
     ensure
       ActiveRecord::Base.connection.drop_table("posts", if_exists: true) # force drop posts table for test.
     end
 
-    test "skips checking for schema cache dump when all databases skipping database tasks" do
-      app_file "config/database.yml", <<-YAML
-        development:
-          database: storage/default.sqlite3
-          adapter: sqlite3
-          database_tasks: false
-      YAML
-
-      add_to_config <<-RUBY
-        config.eager_load = true
-      RUBY
-
-      assert_nothing_raised do
-        app("development")
-      end
-    end
-
     test "expire schema cache dump" do
       rails %w(generate model post title:string)
       rails %w(db:migrate db:schema:cache:dump db:rollback)
@@ -264,10 +249,15 @@ def show
         config.eager_load = true
       RUBY
 
-      silence_warnings do
+      Dir.chdir(app_path) do
         app("development")
+
+        _, error = capture_io do
+          assert_not ActiveRecord::Base.connection.schema_cache.data_sources("posts")
+        end
+
+        assert_match(/Ignoring db\/schema_cache\.yml because it has expired/, error)
       end
-      assert_not ActiveRecord::Base.connection.schema_cache.data_sources("posts")
     end
 
     test "expire schema cache dump if the version can't be checked because the database is unhealthy" do
@@ -279,18 +269,20 @@ def show
       RUBY
 
       with_unhealthy_database do
-        silence_warnings do
+        Dir.chdir(app_path) do
           app("development")
-        end
 
-        assert_not_nil ActiveRecord::Base.connection_pool.schema_reflection.instance_variable_get(:@cache)
+          assert_raises ActiveRecord::ConnectionNotEstablished do
+            ActiveRecord::Base.connection.execute("SELECT 1")
+          end
 
-        assert_raises ActiveRecord::ConnectionNotEstablished do
-          ActiveRecord::Base.connection.execute("SELECT 1")
-        end
+          _, error = capture_io do
+            assert_raises ActiveRecord::ConnectionNotEstablished do
+              ActiveRecord::Base.connection.schema_cache.columns("posts")
+            end
+          end
 
-        assert_raises ActiveRecord::ConnectionNotEstablished do
-          ActiveRecord::Base.connection.schema_cache.columns("posts")
+          assert_match(/Failed to validate the schema cache because of ActiveRecord::ConnectionNotEstablished/, error)
         end
       end
     end
@@ -304,8 +296,11 @@ def show
         config.active_record.check_schema_cache_dump_version = false
       RUBY
 
-      app("development")
-      assert ActiveRecord::Base.connection_pool.schema_reflection.data_sources(:__unused__, "posts")
+      Dir.chdir(app_path) do
+        app("development")
+
+        assert ActiveRecord::Base.connection_pool.schema_reflection.data_sources(:__unused__, "posts")
+      end
     end
 
     test "does not expire schema cache dump if check_schema_cache_dump_version is false and the database unhealthy" do
@@ -318,11 +313,13 @@ def show
       RUBY
 
       with_unhealthy_database do
-        app("development")
+        Dir.chdir(app_path) do
+          app("development")
 
-        assert ActiveRecord::Base.connection_pool.schema_reflection.data_sources(:__unused__, "posts")
-        assert_raises ActiveRecord::ConnectionNotEstablished do
-          ActiveRecord::Base.connection.execute("SELECT 1")
+          assert ActiveRecord::Base.connection_pool.schema_reflection.data_sources(:__unused__, "posts")
+          assert_raises ActiveRecord::ConnectionNotEstablished do
+            ActiveRecord::Base.connection.execute("SELECT 1")
+          end
         end
       end
     end