Merge pull request rails#43273 from p8/actionpack/add-fallback-host-for-rack-system-tests

Add fallback host for SystemTestCase driven by RackTest

Author: rafaelfranca

actionpack/lib/action_dispatch/system_test_case.rb

@@ -115,6 +115,8 @@ class SystemTestCase < ActiveSupport::TestCase
     include SystemTesting::TestHelpers::SetupAndTeardown
     include SystemTesting::TestHelpers::ScreenshotHelper
 
+    DEFAULT_HOST = "http://127.0.0.1"
+
     def initialize(*) # :nodoc:
       super
       self.class.driven_by(:selenium) unless self.class.driver?
@@ -166,7 +168,11 @@ def url_helpers
               include ActionDispatch.test_app.routes.mounted_helpers
 
               def url_options
-                default_url_options.reverse_merge(host: Capybara.app_host || Capybara.current_session.server_url)
+                default_url_options.reverse_merge(host: app_host)
+              end
+
+              def app_host
+                Capybara.app_host || Capybara.current_session.server_url || DEFAULT_HOST
               end
             end.new
           end

actionpack/test/dispatch/system_testing/system_test_case_test.rb

@@ -36,6 +36,10 @@ class SetDriverToSeleniumHeadlessFirefoxTest < DrivenBySeleniumWithHeadlessFiref
 end
 
 class SetHostTest < DrivenByRackTest
+  teardown do
+    Capybara.app_host = nil
+  end
+
   test "overrides host" do
     assert_deprecated do
       host! "http://example.com"

railties/test/application/system_test_case_test.rb

@@ -26,7 +26,22 @@ def teardown
     assert_not_includes(ActionDispatch::SystemTestCase.runnable_methods, :test_foo_url)
   end
 
-  test "system tests set the Capybara host in the url_options by default" do
+  test "system tests use 127.0.0.1 in the url_options be default" do
+    app_file "config/routes.rb", <<-RUBY
+      Rails.application.routes.draw do
+        get 'foo', to: 'foo#index', as: 'test_foo'
+      end
+    RUBY
+
+    app("test")
+    rack_test_case = Class.new(ActionDispatch::SystemTestCase) do
+      driven_by :rack_test
+    end
+    system_test = rack_test_case.new("my_test")
+    assert_equal("http://127.0.0.1/foo", system_test.test_foo_url)
+  end
+
+  test "system tests use Capybara.app_host in the url_options if present" do
     app_file "config/routes.rb", <<-RUBY
       Rails.application.routes.draw do
         get 'foo', to: 'foo#index', as: 'test_foo'