Merge pull request rails#50061 from andrewn617/database-configs-for-with-symbol

DatabaseConfigurations#configs_for can accept a symbol in the name param

Author: eileencodes

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   `DatabaseConfigurations#configs_for` can accept a symbol in the `name` parameter.
+
+    *Andrew Novoselac*
+
 *   Fix `where(field: values)` queries when `field` is a serialized attribute
     (for example, when `field` uses `ActiveRecord::Base.serialize` or is a JSON
     column).

activerecord/lib/active_record/database_configurations.rb

@@ -113,7 +113,7 @@ def configs_for(env_name: nil, name: nil, config_key: nil, include_hidden: false
 
       if name
         configs.find do |db_config|
-          db_config.name == name
+          db_config.name == name.to_s
         end
       else
         configs

activerecord/test/cases/database_configurations_test.rb

@@ -35,6 +35,17 @@ def test_configs_for_getter_with_name
     ENV["RAILS_ENV"] = previous_env
   end
 
+  def test_configs_for_with_name_symbol
+    previous_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "arunit2"
+
+    config = ActiveRecord::Base.configurations.configs_for(name: :primary)
+
+    assert_equal "arunit2", config.env_name
+    assert_equal "primary", config.name
+  ensure
+    ENV["RAILS_ENV"] = previous_env
+  end
+
   def test_configs_for_getter_with_env_and_name
     config = ActiveRecord::Base.configurations.configs_for(env_name: "arunit", name: "primary")