Undefine with on NilClass and other common immediate types

with isn't usable on immediates, so we might as well undefine the
method in common immediate classes to avoid potential confusion.

Author: byroot

activesupport/lib/active_support/core_ext/object/with.rb

@@ -36,3 +36,9 @@ def with(**attributes)
     end
   end
 end
+
+# #with isn't usable on immediates, so we might as well undefine the
+# method in common immediate classes to avoid potential confusion.
+[NilClass, TrueClass, FalseClass, Integer, Float].each do |klass|
+  klass.undef_method(:with)
+end

activesupport/test/core_ext/object/with_test.rb

@@ -87,4 +87,12 @@ def initialize
     end
     assert_equal :mixed, @object.mixed_attr
   end
+
+  test "basic immediates don't respond to #with" do
+    assert_not_respond_to nil, :with
+    assert_not_respond_to true, :with
+    assert_not_respond_to false, :with
+    assert_not_respond_to 1, :with
+    assert_not_respond_to 1.0, :with
+  end
 end