Merge pull request rails#49931 from jonathanhefner/javascript_package_test-update-all

Update `JavascriptPackageTest` tests

Author: jonathanhefner

actioncable/test/javascript_package_test.rb

@@ -4,10 +4,16 @@
 
 class JavascriptPackageTest < ActiveSupport::TestCase
   def test_compiled_code_is_in_sync_with_source_code
-    compiled_file = File.expand_path("../app/assets/javascripts/action_cable.js", __dir__)
+    compiled_files = %w[
+      app/assets/javascripts/actioncable.js
+      app/assets/javascripts/actioncable.esm.js
+      app/assets/javascripts/action_cable.js
+    ].map do |file|
+      Pathname(file).expand_path("#{__dir__}/..")
+    end
 
-    assert_no_changes -> { File.read(compiled_file) } do
-      system "yarn build"
+    assert_no_changes -> { compiled_files.map(&:read) } do
+      system "yarn build", exception: true
     end
   end
 end

actionview/test/javascript_package_test.rb

@@ -2,15 +2,15 @@
 
 class JavascriptPackageTest < ActiveSupport::TestCase
   def test_compiled_code_is_in_sync_with_source_code
-    assert_no_changes -> {
-      %w[
-        app/assets/javascripts/rails-ujs.js
-        app/assets/javascripts/rails-ujs.esm.js
-      ].map { |compiled_file|
-        File.read(File.expand_path("../#{compiled_file}", __dir__))
-      }
-    } do
-      system "yarn build"
+    compiled_files = %w[
+      app/assets/javascripts/rails-ujs.js
+      app/assets/javascripts/rails-ujs.esm.js
+    ].map do |file|
+      Pathname(file).expand_path("#{__dir__}/..")
+    end
+
+    assert_no_changes -> { compiled_files.map(&:read) } do
+      system "yarn build", exception: true
     end
   end
 end

activestorage/test/javascript_package_test.rb

@@ -4,10 +4,15 @@
 
 class JavascriptPackageTest < ActiveSupport::TestCase
   def test_compiled_code_is_in_sync_with_source_code
-    compiled_file = File.expand_path("../app/assets/javascripts/activestorage.js", __dir__)
+    compiled_files = %w[
+      app/assets/javascripts/activestorage.js
+      app/assets/javascripts/activestorage.esm.js
+    ].map do |file|
+      Pathname(file).expand_path("#{__dir__}/..")
+    end
 
-    assert_no_changes -> { File.read(compiled_file) } do
-      system "yarn build"
+    assert_no_changes -> { compiled_files.map(&:read) } do
+      system "yarn build", exception: true
     end
   end
 end