Merge pull request rails#52464 from Shopify/sql-for-insert-no-binds

`sql_for_insert` doesn't need to concern itself about binds

Author: byroot

activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb

@@ -155,7 +155,7 @@ def exec_query(sql, name = "SQL", binds = [], prepare: false)
       # `nil` is the default value and maintains default behavior. If an array of column names is passed -
       # the result will contain values of the specified columns from the inserted row.
       def exec_insert(sql, name = nil, binds = [], pk = nil, sequence_name = nil, returning: nil)
-        sql, binds = sql_for_insert(sql, pk, binds, returning)
+        sql = sql_for_insert(sql, pk, returning)
         internal_exec_query(sql, name, binds)
       end
 
@@ -707,7 +707,7 @@ def select(sql, name = nil, binds = [], prepare: false, async: false, allow_retr
           end
         end
 
-        def sql_for_insert(sql, pk, binds, returning) # :nodoc:
+        def sql_for_insert(sql, pk, returning) # :nodoc:
           if supports_insert_returning?
             if pk.nil?
               # Extract the table from the insert sql. Yuck.
@@ -721,7 +721,7 @@ def sql_for_insert(sql, pk, binds, returning) # :nodoc:
             sql = "#{sql} RETURNING #{returning_columns_statement}" if returning_columns.any?
           end
 
-          [sql, binds]
+          sql
         end
 
         def last_inserted_id(result)

activerecord/lib/active_record/connection_adapters/trilogy/database_statements.rb

@@ -5,7 +5,7 @@ module ConnectionAdapters
     module Trilogy
       module DatabaseStatements
         def exec_insert(sql, name, binds, pk = nil, sequence_name = nil, returning: nil) # :nodoc:
-          sql, _binds = sql_for_insert(sql, pk, binds, returning)
+          sql = sql_for_insert(sql, pk, returning)
           internal_execute(sql, name)
         end