Merge pull request rails#50192 from sbfaulkner/memory-store-unless-exist

Fix MemoryStore#write with unless_exist and namespace

Author: jonathanhefner

activesupport/lib/active_support/cache/memory_store.rb

@@ -210,7 +210,7 @@ def read_entry(key, **options)
         def write_entry(key, entry, **options)
           payload = serialize_entry(entry, **options)
           synchronize do
-            return false if options[:unless_exist] && exist?(key)
+            return false if options[:unless_exist] && exist?(key, namespace: nil)
 
             old_payload = @data[key]
             if old_payload

activesupport/test/cache/stores/memory_store_test.rb

@@ -61,6 +61,28 @@ def test_nil_coder_bypasses_mutation_safeguard
     assert_same value, @cache.read("key")
   end
 
+  def test_write_with_unless_exist
+    assert_equal true, @cache.write(1, "aaaaaaaaaa")
+    assert_equal false, @cache.write(1, "aaaaaaaaaa", unless_exist: true)
+    @cache.write(1, nil)
+    assert_equal false, @cache.write(1, "aaaaaaaaaa", unless_exist: true)
+  end
+
+  def test_namespaced_write_with_unless_exist
+    namespaced_cache = lookup_store(expires_in: 60, namespace: "foo")
+
+    assert_equal true, namespaced_cache.write(1, "aaaaaaaaaa")
+    assert_equal false, namespaced_cache.write(1, "aaaaaaaaaa", unless_exist: true)
+    namespaced_cache.write(1, nil)
+    assert_equal false, namespaced_cache.write(1, "aaaaaaaaaa", unless_exist: true)
+  end
+
+  def test_write_expired_value_with_unless_exist
+    assert_equal true, @cache.write(1, "aaaa", expires_in: 1.second)
+    travel 2.seconds
+    assert_equal true, @cache.write(1, "bbbb", expires_in: 1.second, unless_exist: true)
+  end
+
   private
     def compression_always_disabled_by_default?
       true
@@ -187,17 +209,4 @@ def test_cache_different_object_ids_string
     assert_not_equal item.object_id, read_item.object_id
     assert_not_equal read_item.object_id, @cache.read(key).object_id
   end
-
-  def test_write_with_unless_exist
-    assert_equal true, @cache.write(1, "aaaaaaaaaa")
-    assert_equal false, @cache.write(1, "aaaaaaaaaa", unless_exist: true)
-    @cache.write(1, nil)
-    assert_equal false, @cache.write(1, "aaaaaaaaaa", unless_exist: true)
-  end
-
-  def test_write_expired_value_with_unless_exist
-    assert_equal true, @cache.write(1, "aaaa", expires_in: 1.second)
-    travel 2.seconds
-    assert_equal true, @cache.write(1, "bbbb", expires_in: 1.second, unless_exist: true)
-  end
 end