[rail_inspector] Use Prism for Visitor::Attribute

Author: skipkayhil

tools/rail_inspector/lib/rail_inspector/visitor/attribute.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require "syntax_tree"
+require "prism"
 
 module RailInspector
   module Visitor
-    class Attribute < SyntaxTree::Visitor
+    class Attribute < Prism::Visitor
       attr_reader :attribute_map
 
       def initialize
@@ -13,31 +13,30 @@ def initialize
       end
 
       def with_namespace(node)
-        @namespace_stack << node.constant.constant.value
+        @namespace_stack << node.constant_path.name
         visit_child_nodes(node)
         @namespace_stack.pop
       end
 
-      visit_method alias_method :visit_module, :with_namespace
+      alias visit_class_node with_namespace
+      alias visit_module_node with_namespace
 
-      visit_method alias_method :visit_class, :with_namespace
-
-      visit_method def visit_command(node)
-        attr_access = node.message.value
+      def visit_call_node(node)
+        attr_access = node.name
         return unless ATTRIBUTE_METHODS.include?(attr_access)
 
         full_namespace = @namespace_stack.join("::")
 
         @attribute_map[full_namespace] ||= {}
         @attribute_map[full_namespace][attr_access] ||= Set.new
 
-        attributes = node.arguments.parts.map { |p| p.value.value }
+        attributes = node.arguments.arguments.map { |p| p.value }
 
         @attribute_map[full_namespace][attr_access].merge(attributes)
       end
 
       private
-        ATTRIBUTE_METHODS = %w[attr_accessor attr_reader attr_writer]
+        ATTRIBUTE_METHODS = %i[attr_accessor attr_reader attr_writer]
     end
   end
 end

tools/rail_inspector/test/rail_inspector/visitor/attribute_test.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "rail_inspector/visitor/attribute"
+
+class AttributeTest < Minitest::Test
+  def test_parses_attributes
+    source = <<~FILE
+    module Rails
+      attr_accessor :logger
+
+      class Application
+        class Configuration
+          attr_accessor :yjit
+
+          attr_reader :log_level
+        end
+      end
+    end
+    FILE
+
+    visitor = RailInspector::Visitor::Attribute.new
+    Prism.parse(source).value.accept(visitor)
+
+    assert_equal %w[logger], visitor.attribute_map["Rails"][:attr_accessor].to_a
+
+    config_map = visitor.attribute_map["Rails::Application::Configuration"]
+
+    assert_equal %w[yjit], config_map[:attr_accessor].to_a
+    assert_equal %w[log_level], config_map[:attr_reader].to_a
+  end
+end

tools/rail_inspector/test/test_helper.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 
 require "active_support"
+require "minitest/autorun"