Skip to content

Commit f4a7942

Browse files
authored
Update tests to support guarded InstrumentationSubscriberError
1 parent 8afcbb6 commit f4a7942

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

activerecord/test/cases/adapter_test.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,10 @@ def test_numeric_value_out_of_ranges_are_translated_to_specific_exception
213213
def test_exceptions_from_notifications_are_not_translated
214214
original_error = StandardError.new("This StandardError shouldn't get translated")
215215
subscriber = ActiveSupport::Notifications.subscribe("sql.active_record") { raise original_error }
216-
actual_error = assert_raises(StandardError) do
216+
wrapped_error = assert_raises(ActiveSupport::Notifications::InstrumentationSubscriberError) do
217217
@connection.execute("SELECT * FROM posts")
218218
end
219+
actual_error = wrapped_error.exceptions.first
219220

220221
assert_equal original_error, actual_error
221222

activerecord/test/cases/query_cache_test.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,11 +489,13 @@ def test_query_cache_does_not_allow_sql_key_mutation
489489
payload[:sql].downcase!
490490
end
491491

492-
assert_raises FrozenError do
492+
error = assert_raises ActiveSupport::Notifications::InstrumentationSubscriberError do
493493
ActiveRecord::Base.cache do
494494
assert_queries(1) { Task.find(1); Task.find(1) }
495495
end
496496
end
497+
498+
assert error.exceptions.first.is_a?(FrozenError)
497499
ensure
498500
ActiveSupport::Notifications.unsubscribe subscriber
499501
end

0 commit comments

Comments
 (0)