Merge pull request rails#43397 from composerinteralia/replace-more-ableist-language

Replace more ableist language

Author: eileencodes

actionpack/lib/action_controller/test_case.rb

@@ -627,7 +627,7 @@ def document_root_element
         end
 
         def check_required_ivars
-          # Sanity check for required instance variables so we can give an
+          # Check for required instance variables so we can give an
           # understandable error message.
           [:@routes, :@controller, :@request, :@response].each do |iv_name|
             if !instance_variable_defined?(iv_name) || instance_variable_get(iv_name).nil?

actionpack/test/dispatch/system_testing/driver_test.rb

@@ -160,7 +160,7 @@ class DriverTest < ActiveSupport::TestCase
   end
 
   test "does not configure browser if driver is not :selenium" do
-    # sanity check
+    # Check that it does configure browser if the driver is :selenium
     assert ActionDispatch::SystemTesting::Driver.new(:selenium).instance_variable_get(:@browser)
 
     assert_nil ActionDispatch::SystemTesting::Driver.new(:rack_test).instance_variable_get(:@browser)

actionpack/test/dispatch/test_request_test.rb

@@ -3,7 +3,7 @@
 require "abstract_unit"
 
 class TestRequestTest < ActiveSupport::TestCase
-  test "sane defaults" do
+  test "reasonable defaults" do
     env = ActionDispatch::TestRequest.create.env
 
     assert_equal "GET", env.delete("REQUEST_METHOD")

activemodel/test/cases/attribute_test.rb

@@ -225,7 +225,7 @@ def assert_valid_value(*)
       changed = attribute.with_value_from_user("foo")
       forgotten = changed.forgetting_assignment
 
-      assert changed.changed? # sanity check
+      assert changed.changed? # Check to avoid a false positive
       assert_not_predicate forgotten, :changed?
     end
 

activerecord/lib/active_record/associations/association.rb

@@ -295,7 +295,7 @@ def foreign_key_present?
 
         # Raises ActiveRecord::AssociationTypeMismatch unless +record+ is of
         # the kind of the class of the associated objects. Meant to be used as
-        # a sanity check when you are about to assign an associated record.
+        # a safety check when you are about to assign an associated record.
         def raise_on_type_mismatch!(record)
           unless record.is_a?(reflection.klass)
             fresh_class = reflection.class_name.safe_constantize

activerecord/test/cases/adapters/postgresql/connection_test.rb

@@ -141,7 +141,7 @@ def test_statement_key_is_logged
     def test_reconnection_after_actual_disconnection_with_verify
       original_connection_pid = @connection.query("select pg_backend_pid()")
 
-      # Sanity check.
+      # Double check we are connected to begin with
       assert_predicate @connection, :active?
 
       secondary_connection = ActiveRecord::Base.connection_pool.checkout

activerecord/test/cases/adapters/postgresql/rename_table_test.rb

@@ -14,14 +14,11 @@ def teardown
   end
 
   test "renaming a table also renames the primary key index" do
-    # sanity check
-    assert_equal 1, num_indices_named("before_rename_pkey")
-    assert_equal 0, num_indices_named("after_rename_pkey")
-
-    @connection.rename_table :before_rename, :after_rename
-
-    assert_equal 0, num_indices_named("before_rename_pkey")
-    assert_equal 1, num_indices_named("after_rename_pkey")
+    assert_changes(-> { num_indices_named("before_rename_pkey") }, from: 1, to: 0) do
+      assert_changes(-> { num_indices_named("after_rename_pkey") }, from: 0, to: 1) do
+        @connection.rename_table :before_rename, :after_rename
+      end
+    end
   end
 
   private

activerecord/test/cases/associations/has_many_associations_test.rb

@@ -768,9 +768,9 @@ def test_update_all_on_association_accessed_before_save_with_explicit_foreign_ke
     assert_equal firm.clients.count, firm.clients.update_all(description: "Great!")
   end
 
-  def test_belongs_to_sanity
+  def test_belongs_to_with_new_object
     c = Client.new
-    assert_nil c.firm, "belongs_to failed sanity check on new object"
+    assert_nil c.firm, "belongs_to failed on new object"
   end
 
   def test_find_ids

activerecord/test/cases/attribute_methods_test.rb

@@ -1085,7 +1085,7 @@ def some_method_that_is_not_on_super
     model = @target.select("id").last!
 
     assert_equal ["id"], model.attribute_names
-    # Sanity check, make sure other columns exist.
+    # Ensure other columns exist.
     assert_not_equal ["id"], @target.column_names
   end
 

activerecord/test/cases/autosave_association_test.rb

@@ -1290,9 +1290,9 @@ def test_should_still_work_without_an_associated_model
   end
 
   def test_should_automatically_save_the_associated_model
-    @pirate.ship.name = "The Vile Insanity"
+    @pirate.ship.name = "The Vile Serpent"
     @pirate.save
-    assert_equal "The Vile Insanity", @pirate.reload.ship.name
+    assert_equal "The Vile Serpent", @pirate.reload.ship.name
   end
 
   def test_changed_for_autosave_should_handle_cycles
@@ -1306,9 +1306,9 @@ def test_changed_for_autosave_should_handle_cycles
   end
 
   def test_should_automatically_save_bang_the_associated_model
-    @pirate.ship.name = "The Vile Insanity"
+    @pirate.ship.name = "The Vile Serpent"
     @pirate.save!
-    assert_equal "The Vile Insanity", @pirate.reload.ship.name
+    assert_equal "The Vile Serpent", @pirate.reload.ship.name
   end
 
   def test_should_automatically_validate_the_associated_model
@@ -1376,7 +1376,7 @@ def test_should_still_raise_an_ActiveRecordRecord_Invalid_exception_if_we_want_t
 
   def test_should_not_save_and_return_false_if_a_callback_cancelled_saving
     pirate = Pirate.new(catchphrase: "Arr")
-    ship = pirate.build_ship(name: "The Vile Insanity")
+    ship = pirate.build_ship(name: "The Vile Serpent")
     ship.cancel_save_from_callback = true
 
     assert_no_difference "Pirate.count" do
@@ -1390,7 +1390,7 @@ def test_should_rollback_any_changes_if_an_exception_occurred_while_saving
     before = [@pirate.catchphrase, @pirate.ship.name]
 
     @pirate.catchphrase = "Arr"
-    @pirate.ship.name = "The Vile Insanity"
+    @pirate.ship.name = "The Vile Serpent"
 
     # Stub the save method of the @pirate.ship instance to raise an exception
     class << @pirate.ship
@@ -1472,9 +1472,9 @@ def setup
 
   def test_should_still_work_without_an_associated_model
     @pirate.destroy
-    @ship.reload.name = "The Vile Insanity"
+    @ship.reload.name = "The Vile Serpent"
     @ship.save
-    assert_equal "The Vile Insanity", @ship.reload.name
+    assert_equal "The Vile Serpent", @ship.reload.name
   end
 
   def test_should_automatically_save_the_associated_model
@@ -1523,7 +1523,7 @@ def test_should_still_raise_an_ActiveRecordRecord_Invalid_exception_if_we_want_t
   end
 
   def test_should_not_save_and_return_false_if_a_callback_cancelled_saving
-    ship = Ship.new(name: "The Vile Insanity")
+    ship = Ship.new(name: "The Vile Serpent")
     pirate = ship.build_pirate(catchphrase: "Arr")
     pirate.cancel_save_from_callback = true
 
@@ -1538,7 +1538,7 @@ def test_should_rollback_any_changes_if_an_exception_occurred_while_saving
     before = [@ship.pirate.catchphrase, @ship.name]
 
     @ship.pirate.catchphrase = "Arr"
-    @ship.name = "The Vile Insanity"
+    @ship.name = "The Vile Serpent"
 
     # Stub the save method of the @ship.pirate instance to raise an exception
     class << @ship.pirate
@@ -1553,7 +1553,7 @@ def save(**)
   end
 
   def test_should_not_load_the_associated_model
-    assert_queries(1) { @ship.name = "The Vile Insanity"; @ship.save! }
+    assert_queries(1) { @ship.name = "The Vile Serpent"; @ship.save! }
   end
 
   def test_should_save_with_non_nullable_foreign_keys