Skip to content

Commit fa1a4b6

Browse files
author
David Heinemeier Hansson
committed
Let jsbundling-rails expand without requiring a change in Rails
1 parent 8380816 commit fa1a4b6

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

railties/lib/rails/generators/app_base.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,13 +294,10 @@ def jbuilder_gemfile_entry
294294
def javascript_gemfile_entry
295295
return [] if options[:skip_javascript]
296296

297-
case options[:javascript]
298-
when "importmap"
297+
if options[:javascript] == "importmap"
299298
GemfileEntry.version("importmap-rails", ">= 0.3.4", "Manage modern JavaScript using ESM without transpiling or bundling")
300-
when "webpack", "esbuild", "rollup"
301-
GemfileEntry.version "jsbundling-rails", "~> 0.1.0", "Bundle and transpile JavaScript with esbuild, rollup.js, or Webpack. Read more: https://github.com/rails/jsbundling-rails"
302299
else
303-
raise "Unknown JavaScript approach: #{options[:javascript]} [options are: importmap, webpack, esbuild, rollup]"
300+
GemfileEntry.version "jsbundling-rails", "~> 0.1.0", "Bundle and transpile JavaScript with a JavaScript bundler. Read more: https://github.com/rails/jsbundling-rails"
304301
end
305302
end
306303

0 commit comments

Comments
 (0)