Skip to content

Commit fa737dc

Browse files
skipkayhilbyroot
andcommitted
Remove test_unit plugin_generator
While looking for templates using the `.rb` extension instead of `.rb.tt`, my search ended up finding this `test_helper.rb` file. ``` $ fd | rg "/templates/.*\.rb$" ./actioncable/lib/rails/generators/channel/templates/application_cable/channel.rb ./actioncable/lib/rails/generators/channel/templates/application_cable/connection.rb ./railties/lib/rails/generators/test_unit/plugin/templates/test_helper.rb ``` Instead of correcting the extension, I opted to remove it because the `test_unit:plugin` generator appears to be unused. Co-Authored-By: Jean Boussier <[email protected]>
1 parent 59501ce commit fa737dc

File tree

4 files changed

+4
-28
lines changed

4 files changed

+4
-28
lines changed

railties/lib/rails/generators/test_unit/plugin/plugin_generator.rb

Lines changed: 0 additions & 15 deletions
This file was deleted.

railties/lib/rails/generators/test_unit/plugin/templates/%file_name%_test.rb.tt

Lines changed: 0 additions & 7 deletions
This file was deleted.

railties/lib/rails/generators/test_unit/plugin/templates/test_helper.rb

Lines changed: 0 additions & 2 deletions
This file was deleted.

railties/test/generators_test.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,18 +181,18 @@ def test_no_color_sets_proper_shell
181181

182182
def test_fallbacks_for_generators_on_find_by_namespace
183183
Rails::Generators.fallbacks[:remarkable] = :test_unit
184-
klass = Rails::Generators.find_by_namespace(:plugin, :remarkable)
184+
klass = Rails::Generators.find_by_namespace(:integration, :remarkable)
185185
assert klass
186-
assert_equal "test_unit:plugin", klass.namespace
186+
assert_equal "test_unit:integration", klass.namespace
187187
ensure
188188
Rails::Generators.fallbacks.delete(:remarkable)
189189
end
190190

191191
def test_fallbacks_for_generators_on_find_by_namespace_with_context
192192
Rails::Generators.fallbacks[:remarkable] = :test_unit
193-
klass = Rails::Generators.find_by_namespace(:remarkable, :rails, :plugin)
193+
klass = Rails::Generators.find_by_namespace(:remarkable, :rails, :integration)
194194
assert klass
195-
assert_equal "test_unit:plugin", klass.namespace
195+
assert_equal "test_unit:integration", klass.namespace
196196
ensure
197197
Rails::Generators.fallbacks.delete(:remarkable)
198198
end

0 commit comments

Comments
 (0)